From 9efc109e987b0f7dff9e95e97c719e2f6d918de2 Mon Sep 17 00:00:00 2001 From: gggeek Date: Fri, 27 Jan 2023 10:05:31 +0000 Subject: [PATCH] docs --- NEWS.md | 3 +++ src/Client.php | 4 ++++ src/Wrapper.php | 3 +++ 3 files changed, 10 insertions(+) diff --git a/NEWS.md b/NEWS.md index 727ec347..16e5f34f 100644 --- a/NEWS.md +++ b/NEWS.md @@ -59,6 +59,9 @@ * fixed: receiving integers which use the '' xml tag +* fixed: setting values to deprecated Response property `cookies` would trigger a PHP notice (introduced in 4.6.0), ex: + `$response->_cookies['name'] = ['value' => 'something'];` + * new: method `PhpXmlRpc::useInteropFaults()` can be used to make the library change the error codes it generates to match the spec described at https://xmlrpc-epi.sourceforge.net/specs/rfc.fault_codes.php diff --git a/src/Client.php b/src/Client.php index 82c32e54..396e0eb9 100644 --- a/src/Client.php +++ b/src/Client.php @@ -682,6 +682,10 @@ class Client */ public function send($req, $timeout = 0, $method = '') { + //if ($method !== '' || $timeout !== 0) { + // trigger_error("Using non-default values for arguments 'method' and 'timeout' when calling method " . __METHOD__ . ' is deprecated', E_USER_DEPRECATED); + //} + // if user does not specify http protocol, use native method of this client // (i.e. method set during call to constructor) if ($method == '') { diff --git a/src/Wrapper.php b/src/Wrapper.php index 04a0a833..c80490a8 100644 --- a/src/Wrapper.php +++ b/src/Wrapper.php @@ -667,6 +667,9 @@ class Wrapper * @param string $classMethod * @param array $extraOptions * @return string + * + * @todo php allows many more characters in identifiers than the xml-rpc spec does. We should make sure to + * replace those (while trying to make sure we are not running in collisions) */ protected function generateMethodNameForClassMethod($className, $classMethod, $extraOptions = array()) { -- 2.47.0