From a23aab1fc2f66b63ba9b7e4b9c9a8f6d58c367d0 Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Thu, 4 Nov 2010 10:32:13 -0700 Subject: [PATCH] Fix typos in comments. --- include/openflow/nicira-ext.h | 2 +- lib/ofp-util.h | 13 +++++++++---- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/include/openflow/nicira-ext.h b/include/openflow/nicira-ext.h index 55b3548d7..fcdbba4f4 100644 --- a/include/openflow/nicira-ext.h +++ b/include/openflow/nicira-ext.h @@ -42,7 +42,7 @@ * vendor-specific details, followed by at least 64 bytes of the failed * request. * - * It would be better to have type-specific vendor extension, e.g. so that + * It would be better to have a type-specific vendor extension, e.g. so that * OFPET_BAD_ACTION could be used with vendor-specific code values. But * OFPET_BAD_ACTION and most other standardized types already specify that * their 'data' values are (the start of) the OpenFlow message being replied diff --git a/lib/ofp-util.h b/lib/ofp-util.h index d72a50bd2..1c683eca9 100644 --- a/lib/ofp-util.h +++ b/lib/ofp-util.h @@ -85,7 +85,12 @@ char *ofp_match_to_literal_string(const struct ofp_match *match); /* OpenFlow vendors. * - * These functions map vendor */ + * These functions map OpenFlow 32-bit vendor IDs (as used in struct + * ofp_vendor_header) into 4-bit values to embed in an "int". The 4-bit values + * are only used internally in Open vSwitch and never appear on the wire, so + * particular codes used are not important. + */ + /* Vendor error numbers currently used in Open vSwitch. */ #define OFPUTIL_VENDORS \ /* vendor name vendor value */ \ @@ -106,19 +111,19 @@ enum ofputil_vendor_codes { * error codes into a single 31-bit space using the following encoding. * (Bit 31 is unused and assumed 0 to avoid negative "int" values.) * - * 31 0 + * 30 0 * +------------------------------------------------------+ * | 0 | success * +------------------------------------------------------+ * * 30 29 0 * +--+---------------------------------------------------+ - * |0 | errno value | errno value + * | 0| errno value | errno value * +--+---------------------------------------------------+ * * 30 29 26 25 16 15 0 * +--+-------+----------------+--------------------------+ - * |1 | 0 | type | code | standard OpenFlow + * | 1| 0 | type | code | standard OpenFlow * +--+-------+----------------+--------------------------+ error * * 30 29 26 25 16 15 0 -- 2.43.0