From c0e5f6cabeeb8153144fead66c1f37a5014d9060 Mon Sep 17 00:00:00 2001 From: Jesse Gross Date: Fri, 2 Oct 2009 10:31:20 -0700 Subject: [PATCH] netdev-linux: Return correct error codes on receive. netdev_linux_receive was returning positive error codes while the interface specifies that it should be returning negative errors. This difference causes a huge increase in (non-existant) packet processing with the userspace datapath. --- lib/netdev-linux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c index 50a0d2da7..c71bdd492 100644 --- a/lib/netdev-linux.c +++ b/lib/netdev-linux.c @@ -370,7 +370,7 @@ netdev_linux_recv(struct netdev *netdev_, void *data, size_t size) if (netdev->tap_fd < 0) { /* Device was opened with NETDEV_ETH_TYPE_NONE. */ - return EAGAIN; + return -EAGAIN; } for (;;) { @@ -382,7 +382,7 @@ netdev_linux_recv(struct netdev *netdev_, void *data, size_t size) VLOG_WARN_RL(&rl, "error receiving Ethernet packet on %s: %s", strerror(errno), netdev_get_name(netdev_)); } - return errno; + return -errno; } } } -- 2.43.0