From e0579aef839ee7bdd4cf13134eb468163cbc8437 Mon Sep 17 00:00:00 2001 From: Tony Mack Date: Wed, 23 May 2012 12:19:48 -0400 Subject: [PATCH] dont use icmp_type if values are None --- sfa/openstack/security_group.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sfa/openstack/security_group.py b/sfa/openstack/security_group.py index 33c62743..99f07f03 100644 --- a/sfa/openstack/security_group.py +++ b/sfa/openstack/security_group.py @@ -30,8 +30,6 @@ class SecurityGroup: to_port = int(ports[1]) else: from_port = to_port = int(ports[0]) - else: - from_port = to_port = None return (from_port, to_port) def _validate_icmp_type_code(self, icmp_type_code): @@ -53,7 +51,7 @@ class SecurityGroup: from_port, to_port = self._validate_port_range(port_range) icmp_type = self._validate_icmp_type_code(icmp_type_code) - if icmp_type: + if icmp_type and icmp_type[0] and icmp_type[1]: from_port, to_port = icmp_type[0], icmp_type[1] if group_name: -- 2.47.0