From e0db215cc39b60892f0b674ca0e7607f6df66d58 Mon Sep 17 00:00:00 2001
From: Thierry Parmentelat <thierry.parmentelat@sophia.inria.fr>
Date: Tue, 23 Nov 2010 19:20:30 +0100
Subject: [PATCH] add a note in GetPersons about a possible privacy leak

---
 PLC/Accessors/Factory.py     | 1 +
 PLC/Filter.py                | 5 +++--
 PLC/Methods/GetPersonTags.py | 4 ----
 PLC/Methods/GetPersons.py    | 2 ++
 PLC/Persons.py               | 3 ---
 PLC/TagTypes.py              | 3 ---
 6 files changed, 6 insertions(+), 12 deletions(-)

diff --git a/PLC/Accessors/Factory.py b/PLC/Accessors/Factory.py
index 9b86a8df..c6e87f36 100644
--- a/PLC/Accessors/Factory.py
+++ b/PLC/Accessors/Factory.py
@@ -45,6 +45,7 @@ taggable_classes = { Node : {'table_class' : Nodes,
 
 # xxx probably defined someplace else
 admin_roles = ['admin']
+person_roles = [ 'admin', 'pi', 'tech', 'user' ]
 all_roles = [ 'admin', 'pi', 'tech', 'user', 'node' ]
 tech_roles = [ 'admin', 'pi', 'tech' ]
 
diff --git a/PLC/Filter.py b/PLC/Filter.py
index 5dc9f9b3..42589e04 100644
--- a/PLC/Filter.py
+++ b/PLC/Filter.py
@@ -1,5 +1,6 @@
-# $Id$
-# $URL$
+#
+# Thierry Parmentelat - INRIA
+#
 from types import StringTypes
 try:
     set
diff --git a/PLC/Methods/GetPersonTags.py b/PLC/Methods/GetPersonTags.py
index 44fbdea7..be85340d 100644
--- a/PLC/Methods/GetPersonTags.py
+++ b/PLC/Methods/GetPersonTags.py
@@ -1,10 +1,6 @@
-# $Id: GetPersonTags.py 14587 2009-07-19 13:18:50Z thierry $
-# $URL: http://svn.planet-lab.org/svn/PLCAPI/tags/PLCAPI-4.3-27/PLC/Methods/GetPersonTags.py $
 #
 # Thierry Parmentelat - INRIA
 #
-# $Revision: 14587 $
-#
 from PLC.Faults import *
 from PLC.Method import Method
 from PLC.Parameter import Parameter, Mixed
diff --git a/PLC/Methods/GetPersons.py b/PLC/Methods/GetPersons.py
index 6302765a..a209b879 100644
--- a/PLC/Methods/GetPersons.py
+++ b/PLC/Methods/GetPersons.py
@@ -52,6 +52,8 @@ class GetPersons(Method):
             if not valid_person_ids:
                 return []
 
+            # xxx this looks suspicious
+            # we need to add this restriction even if person_filter is defined
             if person_filter is None:
                 person_filter = valid_person_ids
 
diff --git a/PLC/Persons.py b/PLC/Persons.py
index e0e4c84b..060a46fc 100644
--- a/PLC/Persons.py
+++ b/PLC/Persons.py
@@ -4,9 +4,6 @@
 # Mark Huang <mlhuang@cs.princeton.edu>
 # Copyright (C) 2006 The Trustees of Princeton University
 #
-# $Id$
-# $URL$
-#
 
 from types import StringTypes
 try:
diff --git a/PLC/TagTypes.py b/PLC/TagTypes.py
index c045a639..f5524356 100644
--- a/PLC/TagTypes.py
+++ b/PLC/TagTypes.py
@@ -1,6 +1,3 @@
-# $Id$
-# $Id$
-# $URL$
 #
 # Thierry Parmentelat - INRIA
 #
-- 
2.47.0