From e93af6a4790492e4eaf6ac4624fda6fcff26f209 Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Thu, 24 Jan 2013 13:19:52 -0800 Subject: [PATCH] process: Check return value of set_nonblocking(). It's unlikely to fail but checking it can't hurt. Found by Coverity. Signed-off-by: Ben Pfaff Acked-by: Ethan Jackson --- lib/process.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/lib/process.c b/lib/process.c index 3fc2e1827..795a136d7 100644 --- a/lib/process.c +++ b/lib/process.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2008, 2009, 2010, 2011, 2012 Nicira, Inc. + * Copyright (c) 2008, 2009, 2010, 2011, 2012, 2013 Nicira, Inc. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -408,14 +408,20 @@ struct stream { static int stream_open(struct stream *s, size_t max_size) { + int error; + s->max_size = max_size; ds_init(&s->log); if (pipe(s->fds)) { VLOG_WARN("failed to create pipe: %s", strerror(errno)); return errno; } - set_nonblocking(s->fds[0]); - return 0; + error = set_nonblocking(s->fds[0]); + if (error) { + close(s->fds[0]); + close(s->fds[1]); + } + return error; } static void -- 2.47.0