From f1d3d273b14a40859229c0d03bc4b2b16e2d93c2 Mon Sep 17 00:00:00 2001 From: Sapan Bhatia Date: Mon, 18 Aug 2014 02:24:22 -0400 Subject: [PATCH] Trying to commit an unsaved object with fields set causes the database to lock up. --- planetstack/ec2_observer/syncstep.py | 3 ++- planetstack/openstack_observer/syncstep.py | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/planetstack/ec2_observer/syncstep.py b/planetstack/ec2_observer/syncstep.py index d5f7523..31fec04 100644 --- a/planetstack/ec2_observer/syncstep.py +++ b/planetstack/ec2_observer/syncstep.py @@ -86,7 +86,8 @@ class SyncStep: except: o.backend_status = str(e) - o.save(update_fields=['backend_status']) + if (o.pk): + o.save(update_fields=['backend_status']) logger.log_exc("sync step failed!") failed.append(o) diff --git a/planetstack/openstack_observer/syncstep.py b/planetstack/openstack_observer/syncstep.py index c77c8d5..324829d 100644 --- a/planetstack/openstack_observer/syncstep.py +++ b/planetstack/openstack_observer/syncstep.py @@ -84,7 +84,8 @@ class SyncStep: except: o.backend_status = str(e) - o.save(update_fields=['backend_status']) + if (o.pk): + o.save(update_fields=['backend_status']) logger.log_exc("sync step failed!") failed.append(o) -- 2.43.0