From: marta <marta@8c455092-636d-4788-adf5-e71def0336e8>
Date: Tue, 17 Nov 2009 16:48:49 +0000 (+0000)
Subject: Always release the reference to the sock structure.
X-Git-Tag: ipfw-0.9-6~4
X-Git-Url: http://git.onelab.eu/?p=ipfw.git;a=commitdiff_plain;h=1a406635eb894da69f2435c4d3ae7517e3c5cd70

Always release the reference to the sock structure.
---

diff --git a/dummynet/ipfw2_mod.c b/dummynet/ipfw2_mod.c
index b072ab5..c6a0699 100644
--- a/dummynet/ipfw2_mod.c
+++ b/dummynet/ipfw2_mod.c
@@ -567,7 +567,7 @@ linux_lookup(const int proto, const __be32 saddr, const __be16 sport,
 #endif
 		ret = 1;
 	}
-	if (1 && !skb->sk) /* the reference came from the lookup */
+	if (1 || !skb->sk) /* the reference came from the lookup */
 		sock_put(sk);
 #undef _CURR_UID
 #undef _CURR_GID