From: Thierry Parmentelat <thierry.parmentelat@inria.fr>
Date: Thu, 5 Dec 2013 10:37:16 +0000 (+0100)
Subject: no need to explicitly add an ‘id’ field in records, just tell dataview to use this.key
X-Git-Url: http://git.onelab.eu/?p=myslice.git;a=commitdiff_plain;h=38077fa6e864ddbb6b66ba2cd4723f6d18800305

no need to explicitly add an ‘id’ field in records, just tell dataview to use this.key
---

diff --git a/plugins/querytable/static/js/querytable.js b/plugins/querytable/static/js/querytable.js
index e927c93b..8712e523 100644
--- a/plugins/querytable/static/js/querytable.js
+++ b/plugins/querytable/static/js/querytable.js
@@ -154,8 +154,6 @@
         }, 
 
         new_record: function(record) {
-	    // xxx having a field named 'id' is a requirement from dataview
-	    record['id']=record[this.key];
 	    this.slick_data.push(record);
         },
 
@@ -354,7 +352,8 @@
         on_all_query_done: function() {
 	    if (debug) messages.debug("1-shot initializing dataTables content with " + this.slick_data.length + " lines");
 	    var start=new Date();
-	    this.slick_dataview.setItems (this.slick_data);
+	    // use this.key as the key for identifying rows
+	    this.slick_dataview.setItems (this.slick_data, this.key);
 	    var duration=new Date()-start;
 	    if (debug) messages.debug("setItems " + duration + " ms");
 	    if (debug_deep) {