From 0551515bf611485519f857dc18d6da6cc2a08ed4 Mon Sep 17 00:00:00 2001 From: Thierry Parmentelat Date: Fri, 9 Oct 2015 09:46:19 +0200 Subject: [PATCH] use ArgumentParser instead of OptionParser in ping.py - make hostname required --- examples/linux/ping.py | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/examples/linux/ping.py b/examples/linux/ping.py index 0200b549..2f7b4ee4 100644 --- a/examples/linux/ping.py +++ b/examples/linux/ping.py @@ -26,24 +26,25 @@ from __future__ import print_function from nepi.execution.ec import ExperimentController -from optparse import OptionParser, SUPPRESS_HELP +# SUPPRESS_HELP was not used here, but: +# to suppress an arg from the help, use +# add_argument( help=argparse.SUPPRESS) +from argparse import ArgumentParser import os -usage = ("usage: %prog -a -u -i ") +parser = ArgumentParser() +parser.add_argument("-u", "--username", dest="username", + help="Username to SSH to remote host") +parser.add_argument("-i", "--ssh-key", dest="ssh_key", + help="Path to private SSH key to be used for connection") +# this is required +parser.add_argument("hostname", type=str) -parser = OptionParser(usage = usage) -parser.add_option("-a", "--hostname", dest="hostname", - help="Remote host", type="str") -parser.add_option("-u", "--username", dest="username", - help="Username to SSH to remote host", type="str") -parser.add_option("-i", "--ssh-key", dest="ssh_key", - help="Path to private SSH key to be used for connection", - type="str") -(options, args) = parser.parse_args() +args = parser.parse_args() -hostname = options.hostname -username = options.username -ssh_key = options.ssh_key +hostname = args.hostname +username = args.username +ssh_key = args.ssh_key ec = ExperimentController(exp_id = "ping-exp") -- 2.43.0