expects the 'interfaces' key in GetSlivers - review logs to always mention module

[nodemanager.git] / net.py

diff --git a/net.py b/net.py
index f451f69..45dee4b 100644 (file)
--- a/net.py
+++ b/net.py
@@ -15,16 +15,19 @@ import bwlimit, logger, iptables, tools
 dev_default = tools.get_default_if()
 
 def start(options, conf):
-    logger.log("net plugin starting up...")
+    logger.log("net: plugin starting up...")
 
 def GetSlivers(data, config, plc):
-    logger.verbose("net:GetSlivers called.")
-    InitInterfaces(plc, data) # writes sysconfig files.
+    logger.verbose("net: GetSlivers called.")
+    if not 'interfaces' in data: 
+        logger.log_missing_data('net.GetSlivers','interfaces')
+        return
+    plnet.InitInterfaces(logger, plc, data)
     if 'OVERRIDES' in dir(config): 
         if config.OVERRIDES.get('net_max_rate') == '-1':
             logger.log("net: Slice and node BW Limits disabled.")
             if len(bwlimit.tc("class show dev %s" % dev_default)): 
-                logger.verbose("*** DISABLING NODE BW LIMITS ***")
+                logger.verbose("net: *** DISABLING NODE BW LIMITS ***")
                 bwlimit.stop()
         else:
             InitNodeLimit(data)
@@ -36,7 +39,6 @@ def GetSlivers(data, config, plc):
 
 
 def InitNodeLimit(data):
-    if not 'networks' in data: return
 
     # query running network interfaces
     devs = sioc.gifconf()
@@ -45,17 +47,17 @@ def InitNodeLimit(data):
     for dev in devs:
         macs[sioc.gifhwaddr(dev).lower()] = dev
 
-    for network in data['networks']:
+    for interface in data['interfaces']:
         # Get interface name preferably from MAC address, falling
         # back on IP address.
-        hwaddr=network['mac']
+        hwaddr=interface['mac']
         if hwaddr <> None: hwaddr=hwaddr.lower()
         if hwaddr in macs:
-            dev = macs[network['mac']]
-        elif network['ip'] in ips:
-            dev = ips[network['ip']]
+            dev = macs[interface['mac']]
+        elif interface['ip'] in ips:
+            dev = ips[interface['ip']]
         else:
-            logger.log('%s: no such interface with address %s/%s' % (network['hostname'], network['ip'], network['mac']))
+            logger.log('net: %s: no such interface with address %s/%s' % (interface['hostname'], interface['ip'], interface['mac']))
             continue
 
         # Get current node cap
@@ -65,10 +67,10 @@ def InitNodeLimit(data):
             old_bwlimit = None
 
         # Get desired node cap
-        if network['bwlimit'] is None or network['bwlimit'] < 0:
+        if interface['bwlimit'] is None or interface['bwlimit'] < 0:
             new_bwlimit = bwlimit.bwmax
         else:
-            new_bwlimit = network['bwlimit']
+            new_bwlimit = interface['bwlimit']
 
         if old_bwlimit != new_bwlimit:
             # Reinitialize bandwidth limits
@@ -82,7 +84,7 @@ def InitI2(plc, data):
     if not 'groups' in data: return
 
     if "Internet2" in data['groups']:
-        logger.log("This is an Internet2 node.  Setting rules.")
+        logger.log("net: This is an Internet2 node.  Setting rules.")
         i2nodes = []
         i2nodeids = plc.GetNodeGroups(["Internet2"])[0]['node_ids']
         for node in plc.GetInterfaces({"node_id": i2nodeids}, ["ip"]):
@@ -104,7 +106,6 @@ def InitI2(plc, data):
             os.popen("/sbin/iptables -t mangle " + cmd)
 
 def InitNAT(plc, data):
-    if not 'networks' in data: return
     
     # query running network interfaces
     devs = sioc.gifconf()
@@ -114,21 +115,21 @@ def InitNAT(plc, data):
         macs[sioc.gifhwaddr(dev).lower()] = dev
 
     ipt = iptables.IPTables()
-    for network in data['networks']:
+    for interface in data['interfaces']:
         # Get interface name preferably from MAC address, falling
         # back on IP address.
-        hwaddr=network['mac']
+        hwaddr=interface['mac']
         if hwaddr <> None: hwaddr=hwaddr.lower()
         if hwaddr in macs:
-            dev = macs[network['mac']]
-        elif network['ip'] in ips:
-            dev = ips[network['ip']]
+            dev = macs[interface['mac']]
+        elif interface['ip'] in ips:
+            dev = ips[interface['ip']]
         else:
-            logger.log('%s: no such interface with address %s/%s' % (network['hostname'], network['ip'], network['mac']))
+            logger.log('net: %s: no such interface with address %s/%s' % (interface['hostname'], interface['ip'], interface['mac']))
             continue
 
         try:
-            settings = plc.GetInterfaceTags({'interface_tag_id': network['interface_tag_ids']})
+            settings = plc.GetInterfaceTags({'interface_tag_id': interface['interface_tag_ids']})
         except:
             continue
 
@@ -153,9 +154,5 @@ def InitNAT(plc, data):
                     ipt.add_pf(fields)
     ipt.commit()
 
-def InitInterfaces(plc, data):
-    if not 'networks' in data: return
-    plnet.InitInterfaces(logger, plc, data)
-
 def start(options, config):
     pass