fix slices that use vsys not deleted correctly

[nodemanager.git] / sliver_lxc.py

diff --git a/sliver_lxc.py b/sliver_lxc.py
index 441b2e6..d61109b 100644 (file)
--- a/sliver_lxc.py
+++ b/sliver_lxc.py
@@ -4,21 +4,23 @@
 
 import subprocess
 import sys
+import time
 import os, os.path
 import grp
+from pwd import getpwnam
 from string import Template
 
 import libvirt
 
 import logger
-import bwlimitlxc as bwlimit
+import plnode.bwlimit as bwlimit
 from initscript import Initscript
 from sliver_libvirt import Sliver_Libvirt
 
 class Sliver_LXC(Sliver_Libvirt, Initscript):
     """This class wraps LXC commands"""
 
-    SHELL = '/bin/sshsh'
+    SHELL = '/usr/sbin/vsh'
     TYPE = 'sliver.LXC'
     # Need to add a tag at myplc to actually use this account
     # type = 'sliver.LXC'
@@ -90,10 +92,15 @@ class Sliver_LXC(Sliver_Libvirt, Initscript):
         command = ['chmod', '755', containerDir]
         logger.log_call(command, timeout=15*60)
 
-        # customize prompt for slice owner
+        # customize prompt for slice owner, + LD_PRELOAD for transparently wrap bind
         dot_profile=os.path.join(containerDir,"root/.profile")
+        ld_preload_msg="""# by default, we define this setting so that calls to bind(2),
+# when invoked on 0.0.0.0, get transparently redirected to the public interface of this node
+# see https://svn.planet-lab.org/wiki/LxcPortForwarding"""
         with open(dot_profile,'w') as f:
             f.write("export PS1='%s@\H \$ '\n"%(name))
+            f.write("%s\n"%ld_preload_msg)
+            f.write("export LD_PRELOAD=/etc/planetlab/lib/bind_public.so\n")
 
         # TODO: set quotas...
 
@@ -129,6 +136,33 @@ class Sliver_LXC(Sliver_Libvirt, Initscript):
         command = ['cp', '/home/%s/.ssh/id_rsa.pub'%name, '%s/root/.ssh/authorized_keys'%containerDir]
         logger.log_call(command, timeout=30)
 
+        logger.log("creating /etc/slicename file in %s" % os.path.join(containerDir,'etc/slicename'))
+        try:
+            file(os.path.join(containerDir,'etc/slicename'), 'w').write(name)
+        except:
+            logger.log_exc("exception while creating /etc/slicename")
+
+        try:
+            file(os.path.join(containerDir,'etc/slicefamily'), 'w').write(vref)
+        except:
+            logger.log_exc("exception while creating /etc/slicefamily")
+
+        uid = None
+        try:
+            uid = getpwnam(name).pw_uid
+        except KeyError:
+            # keyerror will happen if user id was not created successfully
+            logger.log_exc("exception while getting user id")
+
+        if uid is not None:
+            logger.log("uid is %d" % uid)
+            command = ['mkdir', '%s/home/%s' % (containerDir, name)]
+            logger.log_call(command, timeout=10)
+            etcpasswd = os.path.join(containerDir, 'etc/passwd')
+            if os.path.exists(etcpasswd):
+                logger.log("adding user %s id %d to %s" % (name, uid, etcpasswd))
+                file(etcpasswd,'a').write("%s:x:%d:%d::/home/%s:/bin/bash\n" % (name, uid, uid, name))
+
         # Lookup for xid and create template after the user is created so we
         # can get the correct xid based on the name of the slice
         xid = bwlimit.get_xid(name)
@@ -141,10 +175,13 @@ class Sliver_LXC(Sliver_Libvirt, Initscript):
         else:
             logger.log("Cannot find XML template %s"%template_filename_sliceimage)
             return
+
+        interfaces = Sliver_Libvirt.get_interfaces_xml(rec)
+
         try:
             with open(template_filename) as f:
                 template = Template(f.read())
-                xml  = template.substitute(name=name, xid=xid)
+                xml  = template.substitute(name=name, interfaces=interfaces)
         except IOError:
             logger.log('Failed to parse or use XML template file %s'%template_filename)
             return
@@ -185,9 +222,21 @@ class Sliver_LXC(Sliver_Libvirt, Initscript):
         command = ['/usr/sbin/userdel', '-f', '-r', name]
         logger.log_call(command, timeout=15*60)
 
+        if os.path.exists(os.path.join(containerDir,"vsys")):
+            # Slivers with vsys running will fail the subvolume delete.
+            # A more permanent solution may be to ensure that the vsys module
+            # is called before the sliver is destroyed.
+            logger.log("destroying vsys directory and restarting vsys")
+            logger.log_call(["rm", "-fR", os.path.join(containerDir, "vsys")])
+            logger.log_call(["/etc/init.d/vsys", "restart", ])
+
         # Remove rootfs of destroyed domain
         command = ['btrfs', 'subvolume', 'delete', containerDir]
         logger.log_call(command, timeout=60)
 
+        if os.path.exists(containerDir):
+           # oh no, it's still here...
+           logger.log("WARNING: failed to destroy container %s" % containerDir)
+
         logger.verbose('sliver_libvirt: %s destroyed.'%name)