From: smbaker <smbaker@fc16-64.lan>
Date: Tue, 11 Dec 2012 01:16:20 +0000 (-0800)
Subject: error message when module lacks the start method
X-Git-Tag: nodemanager-2.1-15~3
X-Git-Url: http://git.onelab.eu/?p=nodemanager.git;a=commitdiff_plain;h=474c12c7e815776b0eac7dfb858af378bd7e59b2

error message when module lacks the start method
---

diff --git a/nodemanager.py b/nodemanager.py
old mode 100755
new mode 100644
index cdd5e45..e998a04
--- a/nodemanager.py
+++ b/nodemanager.py
@@ -203,6 +203,12 @@ If this is not the case, please remove the pid file %s. -- exiting""" % (other_p
                     # if we fail to load any of these, it's really no need to go on any further
                     if module in NodeManager.core_modules:
                         logger.log("FATAL : failed to load core module %s"%module)
+                except AttributeError, err:
+                    # triggered when module doesn't have a 'start' method
+                    logger.log_exc ("ERROR while starting module %s - skipping:" % module)
+                    # if we fail to load any of these, it's really no need to go on any further
+                    if module in NodeManager.core_modules:
+                        logger.log("FATAL : failed to start core module %s"%module)
 
             # sort on priority (lower first)
             def sort_module_priority (m1,m2):