From: Faiyaz Ahmed Date: Mon, 11 May 2009 15:43:33 +0000 (+0000) Subject: log subprocess calls. X-Git-Url: http://git.onelab.eu/?p=nodemanager.git;a=commitdiff_plain;h=refs%2Fheads%2F1.7 log subprocess calls. --- diff --git a/logger.py b/logger.py index 3fedde9..17ae04c 100644 --- a/logger.py +++ b/logger.py @@ -43,7 +43,12 @@ def log(msg,level=LOG_NODE): def log_call(*args): log('running command %s' % ' '.join(args)) - try: subprocess.check_call(args, close_fds=True) + try: + child = subprocess.Popen(args, stdout=subprocess.PIPE, stderr=subprocess.PIPE, close_fds=True) + child.wait() # wait for proc to hang up + if child.returncode: + raise Exception("command failed:\n stdout - %s\n stderr - %s" % \ + (child.stdout.readlines(), child.stderr.readlines())) except: log_exc() def log_exc(name = None):