From 3b18a711d68f936d7395ade1903fe0875cb5fd9c Mon Sep 17 00:00:00 2001
From: gggeek <giunta.gaetano@gmail.com>
Date: Tue, 5 Jan 2021 16:37:45 +0000
Subject: [PATCH] nitpicks

---
 NEWS                             | 2 +-
 demo/server/proxy.php            | 2 +-
 demo/server/server.php           | 2 +-
 doc/ChangeLog                    | 2 +-
 doc/manual/phpxmlrpc_manual.adoc | 2 +-
 src/Client.php                   | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/NEWS b/NEWS
index c48d643..f3caf81 100644
--- a/NEWS
+++ b/NEWS
@@ -4,7 +4,7 @@ XML-RPC for PHP version 4.5.2 - unreleased
 
 * improved: allow usage of 'epivals' for the 'parameters_type' member of methods definitions in the Server dispatch map
 
-* improved: debugger page title when used from the phpjsonrpc library
+* improved: debugger favicon and page title when used from the phpjsonrpc library
 
 
 XML-RPC for PHP version 4.5.1 - 2021/1/3
diff --git a/demo/server/proxy.php b/demo/server/proxy.php
index 978a235..a0a0f1d 100644
--- a/demo/server/proxy.php
+++ b/demo/server/proxy.php
@@ -60,7 +60,7 @@ function forward_request($req)
     /// @todo find a way to forward client info (such as IP) to server, either
     ///       - as xml comments in the payload, or
     ///       - using std http header conventions, such as X-forwarded-for...
-    $reqMethod = $encoder->decode($req->getParam(1));
+    $reqMethod = $req->getParam(1)->scalarval();
     $pars = $req->getParam(2);
     $req = new PhpXmlRpc\Request($reqMethod);
     foreach ($pars as $par) {
diff --git a/demo/server/server.php b/demo/server/server.php
index 7e49521..4ab3be5 100644
--- a/demo/server/server.php
+++ b/demo/server/server.php
@@ -84,7 +84,7 @@ $signatures = array_merge($signatures, $signatures1, $signatures2, $signatures3,
 PhpXmlRpc::$xmlrpc_null_extension = true;
 
 $s = new Server($signatures, false);
-$s->setdebug(3);
+$s->setDebug(3);
 $s->compress_response = true;
 
 // Out-of-band information: let the client manipulate the server operations.
diff --git a/doc/ChangeLog b/doc/ChangeLog
index 3db05c3..afb9b81 100644
--- a/doc/ChangeLog
+++ b/doc/ChangeLog
@@ -965,7 +965,7 @@ This file will not be updated further.
 
 	* xmlrpc.inc: fixed php_xmlrpc_encode detection of php arrays (again!);
 	removed from wrap_php_function the part about setting a custom error handler
-	(it can be activated using the more general $server->setdebug(3) anyway)
+	(it can be activated using the more general $server->setDebug(3) anyway)
 
 	* xmlrpcs.inc: added to server the capability to trap all processing errors
 	during execution of user functions and add them to debug info inside responses;
diff --git a/doc/manual/phpxmlrpc_manual.adoc b/doc/manual/phpxmlrpc_manual.adoc
index 923d636..97f5ccd 100644
--- a/doc/manual/phpxmlrpc_manual.adoc
+++ b/doc/manual/phpxmlrpc_manual.adoc
@@ -1678,7 +1678,7 @@ The most likely cause is that you are not using the correct URL
 
 To find out what the server is really returning to your client,
       you have to enable the debug mode of the client, using
-      $client->setdebug(1);
+      $client->setDebug(1);
 
 
 ==== How can I save to a file the xml of the xmlrpc responses received from servers?
diff --git a/src/Client.php b/src/Client.php
index e29ba20..2f6444a 100644
--- a/src/Client.php
+++ b/src/Client.php
@@ -91,7 +91,7 @@ class Client
      * It defaults to NULL, which means using US-ASCII and encoding all characters outside of the ASCII range using
      * their xml character entity representation (this has the benefit that line end characters will not be mangled in
      * the transfer, a CR-LF will be preserved as well as a singe LF).
-     *  Valid values are 'US-ASCII', 'UTF-8' and 'ISO-8859-1'
+     * Valid values are 'US-ASCII', 'UTF-8' and 'ISO-8859-1'
      */
     public $request_charset_encoding = '';
 
-- 
2.43.0