From 03269c76af15cd27717415e947ea5171b8935c61 Mon Sep 17 00:00:00 2001 From: Thierry Parmentelat Date: Tue, 5 Apr 2016 17:36:59 +0200 Subject: [PATCH] notes on potential negative impact of utf8_decode --- planetlab/sites/site.php | 3 +++ planetlab/sites/sites.php | 3 +++ 2 files changed, 6 insertions(+) diff --git a/planetlab/sites/site.php b/planetlab/sites/site.php index eb2f291..dab93ca 100644 --- a/planetlab/sites/site.php +++ b/planetlab/sites/site.php @@ -38,7 +38,10 @@ if (empty($sites)) { $site=$sites[0]; // var names to api return +// Thomas Dreibholz suggested that utf8_decode could be non-needed +// and maybe even harmful on modern systems like f23 $sitename= htmlentities(utf8_decode($site['name'])); +// $sitename= htmlentities($site['name']); $abbreviated_name= htmlentities($site['abbreviated_name']); $site_url= $site['url']; $login_base= $site['login_base']; diff --git a/planetlab/sites/sites.php b/planetlab/sites/sites.php index d4ab6b9..8eeab4f 100644 --- a/planetlab/sites/sites.php +++ b/planetlab/sites/sites.php @@ -149,7 +149,10 @@ if ($sites) foreach ($sites as $site) { $table->cell(l_site_t($site_id,$site_id)); } $peers->cell($table,$peer_id); + // Thomas Dreibholz suggested that utf8_decode could be non-needed + // and maybe even harmful on modern systems like f23 $table->cell (l_site_t($site_id,htmlentities(utf8_decode($site['name'])))); + // $table->cell (l_site_t($site_id,htmlentities($site['name']))); $table->cell (l_site_t($site_id,$login_base)); $table->cell (htmlentities($site['abbreviated_name'])); if (plc_is_admin()) { -- 2.43.0