X-Git-Url: http://git.onelab.eu/?p=sfa.git;a=blobdiff_plain;f=sfa%2Fmethods%2FAllocate.py;fp=sfa%2Fmethods%2FAllocate.py;h=c2ecfc553fb7e3f1e1406a8ba77cd18eeb14363e;hp=c8cbb0af5153f04c3d21dc1f5b3353272ebe5a54;hb=04a3f20dc71bf8b3f96b1e3172623aa346a638a7;hpb=c1c136b3042a24604823c6da135308b7c031c234 diff --git a/sfa/methods/Allocate.py b/sfa/methods/Allocate.py index c8cbb0af..c2ecfc55 100644 --- a/sfa/methods/Allocate.py +++ b/sfa/methods/Allocate.py @@ -1,5 +1,5 @@ from sfa.util.faults import SfaInvalidArgument, InvalidRSpec, SfatablesRejected -from sfa.util.sfatime import datetime_to_string +from sfa.util.sfatime import datetime_to_string from sfa.util.xrn import Xrn, urn_to_hrn from sfa.util.method import Method from sfa.util.sfatablesRuntime import run_sfatables @@ -8,6 +8,7 @@ from sfa.storage.parameter import Parameter, Mixed from sfa.rspecs.rspec import RSpec from sfa.util.sfalogging import logger + class Allocate(Method): """ Allocate resources as described in a request RSpec argument @@ -50,37 +51,41 @@ class Allocate(Method): Parameter(type([dict]), "List of credentials"), Parameter(str, "RSpec"), Parameter(dict, "options"), - ] + ] returns = Parameter(str, "Allocated RSpec") def call(self, xrn, creds, rspec, options): xrn = Xrn(xrn, type='slice') # Find the valid credentials - valid_creds = self.api.auth.checkCredentialsSpeaksFor(creds, 'createsliver', xrn.get_hrn(), options=options) + valid_creds = self.api.auth.checkCredentialsSpeaksFor( + creds, 'createsliver', xrn.get_hrn(), options=options) the_credential = Credential(cred=valid_creds[0]) - # use the expiration from the first valid credential to determine when + # use the expiration from the first valid credential to determine when # the slivers should expire. expiration = datetime_to_string(the_credential.expiration) - - self.api.logger.debug("Allocate, received expiration from credential: %s"%expiration) + + self.api.logger.debug( + "Allocate, received expiration from credential: %s" % expiration) # turned off, as passing an empty rspec is indeed useful for cleaning up the slice # # make sure request is not empty # slivers = RSpec(rspec).version.get_nodes_with_slivers() # if not slivers: -# raise InvalidRSpec("Missing or element. Request rspec must explicitly allocate slivers") +# raise InvalidRSpec("Missing or element. Request rspec must explicitly allocate slivers") # flter rspec through sfatables if self.api.interface in ['aggregate']: chain_name = 'INCOMING' elif self.api.interface in ['slicemgr']: chain_name = 'FORWARD-INCOMING' - self.api.logger.debug("Allocate: sfatables on chain %s"%chain_name) + self.api.logger.debug("Allocate: sfatables on chain %s" % chain_name) actual_caller_hrn = the_credential.actual_caller_hrn() - self.api.logger.info("interface: %s\tcaller-hrn: %s\ttarget-hrn: %s\tmethod-name: %s"%(self.api.interface, actual_caller_hrn, xrn.get_hrn(), self.name)) - rspec = run_sfatables(chain_name, xrn.get_hrn(), actual_caller_hrn, rspec) + self.api.logger.info("interface: %s\tcaller-hrn: %s\ttarget-hrn: %s\tmethod-name: %s" % + (self.api.interface, actual_caller_hrn, xrn.get_hrn(), self.name)) + rspec = run_sfatables(chain_name, xrn.get_hrn(), + actual_caller_hrn, rspec) # turned off, as passing an empty rspec is indeed useful for cleaning up the slice # slivers = RSpec(rspec).version.get_nodes_with_slivers() # if not slivers: @@ -88,5 +93,6 @@ class Allocate(Method): # pass this to the driver code in case they need it options['actual_caller_hrn'] = actual_caller_hrn - result = self.api.manager.Allocate(self.api, xrn.get_urn(), creds, rspec, expiration, options) + result = self.api.manager.Allocate( + self.api, xrn.get_urn(), creds, rspec, expiration, options) return result