From: Thierry Parmentelat <thierry.parmentelat@inria.fr>
Date: Fri, 5 Jun 2015 08:10:29 +0000 (+0200)
Subject: remove printing 'name' in low-level record utilities, as UTF-8 values can create... 
X-Git-Tag: sfa-3.1-17~9
X-Git-Url: http://git.onelab.eu/?p=sfa.git;a=commitdiff_plain;h=555a69b1f59e650c28e77952fc4d3985e63e0c4c

remove printing 'name' in low-level record utilities, as UTF-8 values can create serious errors on the server side if ill-configured
---

diff --git a/sfa/storage/model.py b/sfa/storage/model.py
index 3b53517a..347012d7 100644
--- a/sfa/storage/model.py
+++ b/sfa/storage/model.py
@@ -110,7 +110,9 @@ class RegRecord (Base, AlchemyObj):
         result="<Record id=%s, type=%s, hrn=%s, authority=%s" % \
                 (self.record_id, self.type, self.hrn, self.authority)
 #        for extra in ('pointer', 'email', 'name'):
-        for extra in ('email', 'name'):
+#        for extra in ('email', 'name'):
+# displaying names at this point it too dangerous, because of unicode
+        for extra in ('email'):
             if hasattr(self, extra):
                 result += " {}={},".format(extra, getattr(self, extra))
         # skip the uniform '--- BEGIN CERTIFICATE --' stuff
@@ -208,7 +210,8 @@ class RegAuthority (RegRecord):
     # no proper data yet, just hack the typename
     def __repr__ (self):
         result = RegRecord.__repr__(self).replace("Record", "Authority")
-        result.replace(">", " name={}>".format(self.name))
+# here again trying to display names that can be utf8 is too dangerous        
+#        result.replace(">", " name={}>".format(self.name))
         return result
 
     def update_pis (self, pi_hrns, dbsession):