From: Thierry Parmentelat Date: Wed, 30 Apr 2014 10:43:49 +0000 (+0200) Subject: it is dangerous to set defaults to mutable objects like [] or {} X-Git-Tag: sfa-3.1-4~9 X-Git-Url: http://git.onelab.eu/?p=sfa.git;a=commitdiff_plain;h=74d0c3bc711fe8c7d2baa20d6e46c598b22c9fda it is dangerous to set defaults to mutable objects like [] or {} plus, we don't actually use this --- diff --git a/sfa/client/sfaadmin.py b/sfa/client/sfaadmin.py index 2ddf609f..cf88a3a3 100755 --- a/sfa/client/sfaadmin.py +++ b/sfa/client/sfaadmin.py @@ -81,9 +81,9 @@ class RegistryCommands(Commands): save_records_to_file(outfile, records) - def _record_dict(self, xrn=None, type=None, email='', key=None, - slices=[], researchers=[], pis=[], - url=None, description=None, extras={}): + def _record_dict(self, xrn, type, email, key, + slices, researchers, pis, + url, description, extras): record_dict = {} if xrn: if type: