From 031774db6b99361059196ae9b63ecd1f0be9e19a Mon Sep 17 00:00:00 2001 From: Thierry Parmentelat Date: Fri, 1 Apr 2016 11:24:25 +0200 Subject: [PATCH] basestring -> StringType --- sfa/rspecs/version_manager.py | 3 ++- sfa/rspecs/versions/pgv2.py | 3 ++- sfa/util/xml.py | 4 ++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/sfa/rspecs/version_manager.py b/sfa/rspecs/version_manager.py index cedd54f1..e0a604e4 100644 --- a/sfa/rspecs/version_manager.py +++ b/sfa/rspecs/version_manager.py @@ -4,6 +4,7 @@ import os from sfa.util.faults import InvalidRSpec, UnsupportedRSpecVersion from sfa.rspecs.version import RSpecVersion from sfa.util.sfalogging import logger +from sfa.util.py23 import StringType class VersionManager: def __init__(self): @@ -49,7 +50,7 @@ class VersionManager: retval = None if isinstance(version, dict): retval = self._get_version(version.get('type'), version.get('version'), version.get('content_type')) - elif isinstance(version, basestring): + elif isinstance(version, StringType): version_parts = version.split(' ') num_parts = len(version_parts) type = version_parts[0] diff --git a/sfa/rspecs/versions/pgv2.py b/sfa/rspecs/versions/pgv2.py index a4f59630..3e25a376 100644 --- a/sfa/rspecs/versions/pgv2.py +++ b/sfa/rspecs/versions/pgv2.py @@ -8,6 +8,7 @@ from sfa.rspecs.elements.versions.pgv2Node import PGv2Node from sfa.rspecs.elements.versions.pgv2SliverType import PGv2SliverType from sfa.rspecs.elements.versions.pgv2Lease import PGv2Lease from sfa.util.sfalogging import logger +from sfa.util.py23 import StringType class PGv2(RSpecVersion): type = 'ProtoGENI' @@ -204,7 +205,7 @@ class PGv2(RSpecVersion): """ from sfa.rspecs.rspec import RSpec # just copy over all the child elements under the root element - if isinstance(in_rspec, basestring): + if isinstance(in_rspec, StringType): in_rspec = RSpec(in_rspec) nodes = in_rspec.version.get_nodes() diff --git a/sfa/util/xml.py b/sfa/util/xml.py index af151b70..3a38ecc3 100755 --- a/sfa/util/xml.py +++ b/sfa/util/xml.py @@ -164,7 +164,7 @@ class XML: self.namespaces = namespaces self.default_namespace = None self.schema = None - if isinstance(xml, basestring): + if isinstance(xml, StringType): self.parse_xml(xml) if isinstance(xml, XmlElement): self.root = xml @@ -227,7 +227,7 @@ class XML: if isinstance(val, dict): child_element = etree.SubElement(element, key) self.parse_dict(val, key, child_element) - elif isinstance(val, basestring): + elif isinstance(val, StringType): child_element = etree.SubElement(element, key).text = val elif isinstance(value, int): -- 2.43.0