From 32020b2567795112be0435ecaff9455804a0c018 Mon Sep 17 00:00:00 2001 From: Thierry Parmentelat Date: Fri, 5 Jun 2015 12:43:06 +0200 Subject: [PATCH] prettyfied registry manager (+format) --- sfa/managers/registry_manager.py | 86 +++++++++++++++++--------------- 1 file changed, 46 insertions(+), 40 deletions(-) diff --git a/sfa/managers/registry_manager.py b/sfa/managers/registry_manager.py index 8e8eb783..cc5654a6 100644 --- a/sfa/managers/registry_manager.py +++ b/sfa/managers/registry_manager.py @@ -48,11 +48,13 @@ def _normalize_input (record, reg_key, driver_key): # and issue a warning if they were both set and different # as we're overwriting some user data here if driver_key in record: - logger.warning ("normalize_input: incoming record has both values, using %s"%reg_key) + logger.warning ("normalize_input: incoming record has both values, using {}" + .format(reg_key)) record[driver_key] = record[reg_key] # we only have one key set, duplicate for the other one elif driver_key in record: - logger.warning ("normalize_input: you should use '%s' instead of '%s'"%(reg_key,driver_key)) + logger.warning ("normalize_input: you should use '{}' instead of '{}'" + .format(reg_key, driver_key)) record[reg_key] = record[driver_key] def normalize_input_record (record): @@ -69,7 +71,7 @@ def normalize_input_record (record): class RegistryManager: def __init__ (self, config): - logger.info("Creating RegistryManager[%s]"%id(self)) + logger.info("Creating RegistryManager[{}]".format(id(self))) # The GENI GetVersion call def GetVersion(self, api, options): @@ -105,9 +107,9 @@ class RegistryManager: # get record info dbsession = api.dbsession() - record=dbsession.query(RegRecord).filter_by(type=type,hrn=hrn).first() + record = dbsession.query(RegRecord).filter_by(type=type, hrn=hrn).first() if not record: - raise RecordNotFound("hrn=%s, type=%s"%(hrn,type)) + raise RecordNotFound("hrn={}, type={}".format(hrn, type)) # get the callers gid # if caller_xrn is not specified assume the caller is the record @@ -122,7 +124,9 @@ class RegistryManager: else: caller_record = dbsession.query(RegRecord).filter_by(hrn=caller_hrn).first() if not caller_record: - raise RecordNotFound("Unable to associated caller (hrn=%s, type=%s) with credential for (hrn: %s, type: %s)"%(caller_hrn, caller_type, hrn, type)) + raise RecordNotFound( + "Unable to associated caller (hrn={}, type={}) with credential for (hrn: {}, type: {})" + .format(caller_hrn, caller_type, hrn, type)) caller_gid = GID(string=caller_record.gid) object_hrn = record.get_gid_object().get_hrn() @@ -130,8 +134,8 @@ class RegistryManager: rights = api.auth.determine_user_rights(caller_hrn, record) # make sure caller has rights to this object if rights.is_empty(): - raise PermissionError("%s has no rights to %s (%s)" % \ - (caller_hrn, object_hrn, xrn)) + raise PermissionError("{} has no rights to {} ({})" + .format(caller_hrn, object_hrn, xrn)) object_gid = GID(string=record.gid) new_cred = Credential(subject = object_gid.get_subject()) new_cred.set_gid_caller(caller_gid) @@ -208,12 +212,13 @@ class RegistryManager: local_records = dbsession.query(RegRecord).filter(RegRecord.hrn.in_(local_hrns)) if type: local_records = local_records.filter_by(type=type) - local_records=local_records.all() + local_records = local_records.all() for local_record in local_records: augment_with_sfa_builtins(local_record) - logger.info("Resolve, (details=%s,type=%s) local_records=%s "%(details,type,local_records)) + logger.info("Resolve, (details={}, type={}) local_records={} " + .format(details, type, local_records)) local_dicts = [ record.__dict__ for record in local_records ] if details: @@ -229,7 +234,8 @@ class RegistryManager: if hrn in neighbour_dict: record.url=neighbour_dict[hrn].get_url() return - for record in local_records: solve_neighbour_url (record) + for record in local_records: + solve_neighbour_url (record) # convert local record objects to dicts for xmlrpc # xxx somehow here calling dict(record) issues a weird error @@ -270,7 +276,7 @@ class RegistryManager: record_dicts = record_list # if we still have not found the record yet, try the local registry -# logger.debug("before trying local records, %d foreign records"% len(record_dicts)) +# logger.debug("before trying local records, {} foreign records".format(len(record_dicts))) if not record_dicts: recursive = False if ('recursive' in options and options['recursive']): @@ -283,10 +289,10 @@ class RegistryManager: raise MissingAuthority(hrn) if recursive: records = dbsession.query(RegRecord).filter(RegRecord.hrn.startswith(hrn)).all() -# logger.debug("recursive mode, found %d local records"%(len(records))) +# logger.debug("recursive mode, found {} local records".format(len(records))) else: records = dbsession.query(RegRecord).filter_by(authority=hrn).all() -# logger.debug("non recursive mode, found %d local records"%(len(records))) +# logger.debug("non recursive mode, found {} local records".format(len(records))) # so that sfi list can show more than plain names... for record in records: # xxx mystery - again this useless statement is key here so that @@ -294,7 +300,7 @@ class RegistryManager: # object's contents; was first observed with authorities' 'name' column # that would be missing from result as received by client # record.todict() is the place where __dict__ is used - print "DO NOT REMOVE ME before augment_with_sfa_builtins, record=%s"%record + print "DO NOT REMOVE ME before augment_with_sfa_builtins, record={}".format(record) augment_with_sfa_builtins(record) record_dicts = [ record.record_to_dict(exclude_types=(InstrumentedList,)) for record in records ] @@ -314,7 +320,7 @@ class RegistryManager: email = None hrn = Xrn(xrn).get_hrn() dbsession = api.dbsession() - record=dbsession.query(RegUser).filter_by(hrn=hrn).first() + record = dbsession.query(RegUser).filter_by(hrn=hrn).first() if record: email = getattr(record,'email',None) gid = api.auth.hierarchy.create_gid(xrn, create_uuid(), pkey, email=email) @@ -350,9 +356,9 @@ class RegistryManager: def Register(self, api, record_dict): - logger.debug("Register: entering with record_dict=%s"%printable(record_dict)) + logger.debug("Register: entering with record_dict={}".format(printable(record_dict))) normalize_input_record (record_dict) - logger.debug("Register: normalized record_dict=%s"%printable(record_dict)) + logger.debug("Register: normalized record_dict={}".format(printable(record_dict))) dbsession = api.dbsession() hrn, type = record_dict['hrn'], record_dict['type'] @@ -362,7 +368,7 @@ class RegistryManager: raise UnknownSfaType(type) # check if record_dict already exists - existing_records = dbsession.query(RegRecord).filter_by(type=type,hrn=hrn).all() + existing_records = dbsession.query(RegRecord).filter_by(type=type, hrn=hrn).all() if existing_records: raise ExistingRecord(hrn) @@ -412,7 +418,7 @@ class RegistryManager: keys=getattr(record,'reg-keys') # some people send the key as a string instead of a list of strings if isinstance(keys,types.StringTypes): keys=[keys] - logger.debug ("creating %d keys for user %s"%(len(keys),record.hrn)) + logger.debug ("creating {} keys for user {}".format(len(keys), record.hrn)) record.reg_keys = [ RegKey (key) for key in keys ] # update testbed-specific data if needed @@ -429,9 +435,9 @@ class RegistryManager: def Update(self, api, record_dict): - logger.debug("Update: entering with record_dict=%s"%printable(record_dict)) + logger.debug("Update: entering with record_dict={}".format(printable(record_dict))) normalize_input_record (record_dict) - logger.debug("Update: normalized record_dict=%s"%printable(record_dict)) + logger.debug("Update: normalized record_dict={}".format(printable(record_dict))) dbsession = api.dbsession() assert ('type' in record_dict) @@ -497,14 +503,14 @@ class RegistryManager: # record.__dict__ as received by the driver seems to be off # anyway the driver should receive an object # (and then extract __dict__ itself if needed) - print "DO NOT REMOVE ME before driver.update, record=%s"%record + print "DO NOT REMOVE ME before driver.update, record={}".format(record) new_key_pointer = -1 try: (pointer, new_key_pointer) = api.driver.update (record.__dict__, new_record.__dict__, hrn, new_key) except: pass if new_key and new_key_pointer: - record.reg_keys = [ RegKey (new_key, new_key_pointer)] + record.reg_keys = [ RegKey(new_key, new_key_pointer) ] record.gid = gid dbsession.commit() @@ -516,16 +522,16 @@ class RegistryManager: # expecting an Xrn instance def Remove(self, api, xrn, origin_hrn=None): dbsession = api.dbsession() - hrn=xrn.get_hrn() - type=xrn.get_type() - request=dbsession.query(RegRecord).filter_by(hrn=hrn) + hrn = xrn.get_hrn() + type = xrn.get_type() + request = dbsession.query(RegRecord).filter_by(hrn=hrn) if type and type not in ['all', '*']: - request=request.filter_by(type=type) + request = request.filter_by(type=type) record = request.first() if not record: - msg="Could not find hrn %s"%hrn - if type: msg += " type=%s"%type + msg = "Could not find hrn {}".format(hrn) + if type: msg += " type={}".format(type) raise RecordNotFound(msg) type = record.type @@ -564,16 +570,16 @@ class RegistryManager: (ip, port) = api.remote_addr interfaces = api.driver.shell.GetInterfaces({'ip': ip}, ['node_id']) if not interfaces: - raise NonExistingRecord("no such ip %(ip)s" % locals()) + raise NonExistingRecord("no such ip {}".format(ip)) nodes = api.driver.shell.GetNodes([interfaces[0]['node_id']], ['node_id', 'hostname']) if not nodes: - raise NonExistingRecord("no such node using ip %(ip)s" % locals()) + raise NonExistingRecord("no such node using ip {}".format(ip)) node = nodes[0] # look up the sfa record - record=dbsession.query(RegRecord).filter_by(type='node',pointer=node['node_id']).first() + record = dbsession.query(RegRecord).filter_by(type='node', pointer=node['node_id']).first() if not record: - raise RecordNotFound("node with pointer %s"%node['node_id']) + raise RecordNotFound("node with pointer {}".format(node['node_id'])) # generate a new keypair and gid uuid = create_uuid() @@ -601,12 +607,12 @@ class RegistryManager: scp = "/usr/bin/scp" #identity = "/etc/planetlab/root_ssh_key.rsa" identity = "/etc/sfa/root_ssh_key" - scp_options=" -i %(identity)s " % locals() - scp_options+="-o StrictHostKeyChecking=no " % locals() - scp_key_command="%(scp)s %(scp_options)s %(key_filename)s root@%(host)s:%(key_dest)s" %\ - locals() - scp_gid_command="%(scp)s %(scp_options)s %(gid_filename)s root@%(host)s:%(gid_dest)s" %\ - locals() + scp_options = " -i {identity} ".format(**locals()) + scp_options += "-o StrictHostKeyChecking=no " + scp_key_command = "{scp} {scp_options} {key_filename} root@{host}:{key_dest}"\ + .format(**locals()) + scp_gid_command = "{scp} {scp_options} {gid_filename} root@{host}:{gid_dest}"\ + .format(**locals()) all_commands = [scp_key_command, scp_gid_command] -- 2.43.0