From 93687e978298661b0cd2cb2e4ba8cd6e7f5cd1d8 Mon Sep 17 00:00:00 2001 From: Thierry Parmentelat Date: Sun, 4 May 2014 16:24:44 -0400 Subject: [PATCH] review the comment about normalizing input records in register/update --- sfa/managers/registry_manager.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/sfa/managers/registry_manager.py b/sfa/managers/registry_manager.py index bfff502b..48728015 100644 --- a/sfa/managers/registry_manager.py +++ b/sfa/managers/registry_manager.py @@ -26,14 +26,16 @@ from sfa.storage.model import make_record, RegRecord, RegAuthority, RegUser, Reg from sqlalchemy.orm.collections import InstrumentedList ### historical note -- april 2014 -# the myslice chaps rightfully complained about the following discrepency +# the myslice chaps rightfully complained about the following discrepancy # they found that -# * read operations (resolve) expose stuff like e.g. 'reg-researchers', but that -# * write operations (register, update) need e.g. 'researcher' to be set - it ignores 'reg-researchers' +# * read operations (resolve) expose stuff like e.g. +# 'reg-researchers', or 'reg-pis', but that +# * write operations (register, update) need e.g. +# 'researcher' or 'pi' to be set - reg-* are just ignored # # the 'normalize' helper functions below aim at ironing this out -# however in order to break as few as possible we essentially make sure that *both* fields are set -# upon entering the write methods (so again register and update) because some driver code +# however in order to break as few code as possible we essentially make sure that *both* fields are set +# upon entering the write methods (so again register and update) for legacy, as some driver code # might depend on the presence of, say, 'researcher' # registry calls this 'reg-researchers' -- 2.43.0