fix segfault on sface exit in ubuntu
[sface.git] / sface / mainwindow.py
index 620b000..b361b22 100644 (file)
@@ -1,62 +1,97 @@
 import os, os.path
 import sys
 import time
+import traceback
 
 from PyQt4.QtCore import *
 from PyQt4.QtGui import *
 
+import sface.screens
 from sface.config import config
 from sface.logwindow import LogWindow
 from sface.rspecwindow import RSpecWindow
-from sface.screens.configscreen import ConfigScreen
-from sface.screens.mainscreen import MainScreen
-from sface.screens.helpscreen import HelpScreen
+from sface.screens.sfascreen import SfaScreen
 
 # depending on the platform..
+# could probably use Qt's resource system but looks overkill for just one file...
 def locate_image_file (filename):
-    for dir in [ '/usr/share' ] :
+    for dir in [ '/usr/share', '/Applications/sface.app/Contents/Resources/sface' ] :
         for suffix in ['png','jpg']:
             attempt=os.path.join(dir,'images',"%s.%s"%(filename,suffix))
             if os.path.isfile(attempt) : return attempt
     return os.path.join('/could/not/locate/image/file',filename)
-        
+
+def load_screens(dirname):
+    modnames = []
+    for fn in os.listdir(dirname):
+        if not fn.endswith(".py"):
+            continue
+        modname = fn.rsplit(".py",1)[0]
+        if modname == "sfascreen":
+            # ignore this, it's the base class, not a screen
+            continue
+        modnames.append(modname)
+
+    # we want the stock screens to show up in a specific order. plugins can
+    # show up in any order afterward.
+
+    sort_order = ["mainscreen", "configscreen", "helpscreen"]
+    sort_order.reverse()
+    for modname in sort_order:
+        if modname in modnames:
+            modnames.remove(modname)
+            modnames.insert(0,modname)
+
+    # import each module and find whatever class(es) is descendant from
+    # SfaScreen within the module. Might be a better idea to just define a
+    # screens=[] variable in each module
+
+    screens = []
+    for modname in modnames:
+        try:
+            mod = __import__("sface.screens." + modname, fromlist=["modname"])
+        except:
+            print "Exception while importing screen", modname
+            traceback.print_exc()
+            continue
+
+        for object in dir(mod):
+            object = getattr(mod, object)
+            if hasattr(object, "__bases__") and sface.screens.sfascreen.SfaScreen in object.__bases__:
+                screens.append(object)
+
+    return screens
 
 class Nav(QWidget):
-    def __init__(self, parent=None):
+    def __init__(self, screens, parent=None):
         QWidget.__init__(self, parent)
-        
+
         self.title = QLabel("", self)
         scene=QGraphicsScene()
-        pixmap = QPixmap(locate_image_file('graphic-sfa.png'))
+        pixmap = QPixmap(locate_image_file('graphic-sfa64'))
         logolabel=QLabel("",self)
         logolabel.setPixmap(pixmap)
-        self.main = QLabel("", self)
-        self.main.setAlignment(Qt.AlignRight)
-
-        self.config = QLabel("", self)
-        self.config.setAlignment(Qt.AlignRight)
-        
-        self.help = QLabel("", self)
-        self.help.setAlignment(Qt.AlignRight)
 
         hlayout = QHBoxLayout()
         hlayout.addWidget(logolabel)
         hlayout.addWidget(self.title)
         hlayout.addStretch()
-        hlayout.addWidget(QLabel("Go to: ", self))
-        hlayout.addWidget(self.main)
-        hlayout.addWidget(self.config)
-        hlayout.addWidget(self.help)
+        gotolabel=QLabel("Go to: ", self)
+        gotolabel.setAlignment(Qt.AlignRight)
+        hlayout.addWidget(gotolabel)
+
+        self.screenLabels = []
+        for screen in screens:
+            label = QLabel(screen.getLinkText(), self)
+            label.setAlignment(Qt.AlignRight)
+            self.screenLabels.append(label)
+            hlayout.addWidget(label)
+
         self.setLayout(hlayout)
 
     def setTitle(self, title):
         self.title.setText(title)
 
-    def setLinks(self, main, config, help):
-        self.main.setText(main)
-        self.config.setText(config)
-        self.help.setText(help)
-
 
 class Status(QLabel):
     def __init__(self, parent=None):
@@ -86,26 +121,35 @@ class MainWindow(QWidget):
     def __init__(self, parent=None):
         QWidget.__init__(self, parent)
 
-        self.logWindow = LogWindow(self)
-        self.rspecWindow = RSpecWindow(self)
+        # These are top-level windows and should be initialized with parent set
+        # to our parent. Otherwise, getting a segfault on exit in Ubuntu.
+        self.logWindow = LogWindow(parent)
+        self.rspecWindow = RSpecWindow(parent)
 
         self.pix = QLabel(self)
-        self.config_screen = ConfigScreen(self)
-        self.main_screen = MainScreen(self)
-        self.help_screen = HelpScreen(self)
+
+        screenClasses = load_screens(os.path.dirname(sface.screens.__file__))
+        self.screenWidgets = []
 
         self.screens = QStackedWidget(self)
-        self.screens.addWidget(self.main_screen)
-        self.screens.addWidget(self.config_screen)
-        self.screens.addWidget(self.help_screen)
+        for screen in screenClasses:
+            # use a try/catch block to isolate the screen. Third-party plugins
+            # could be buggy.
+            try:
+                screenWidget = screen(self)
+                self.screenWidgets.append(screenWidget)
+                self.screens.addWidget(screenWidget)
+            except:
+                print "Exception while creating screen", screen.__name__
+                traceback.print_exc()
+
         self.screens.addWidget(self.pix)
         self.next_screen = None
 
-        self.nav = Nav(self)
-        self.nav.setTitle(self.main_screen.getTitleText())
-        self.nav.setLinks(self.main_screen.getLinkText(),
-                          self.config_screen.getLinkText(),
-                          self.help_screen.getLinkText())
+        self.nav = Nav(self.screenWidgets, self)
+
+        if self.screenWidgets:
+            self.nav.setTitle(self.screenWidgets[0].getTitleText())
 
         self.status = Status(self)
         self.log = QLabel("<a href='showlog'>Show Log</a>", self)
@@ -124,7 +168,7 @@ class MainWindow(QWidget):
         self.setLayout(layout)
         self.resize(800, 500)
 
-        for link in (self.nav.main, self.nav.config, self.nav.help):
+        for link in self.nav.screenLabels:
             self.connect(link, SIGNAL('linkActivated(QString)'),
                          self.animateToScreen)
 
@@ -153,12 +197,9 @@ class MainWindow(QWidget):
         self.pix.move(0, y)
 
     def animateToScreen(self, link):
-        if link == self.config_screen.name:
-            self.next_screen = self.config_screen
-        elif link == self.main_screen.name:
-            self.next_screen = self.main_screen
-        elif link == self.help_screen.name:
-            self.next_screen = self.help_screen
+        for screen in self.screenWidgets:
+            if link == screen.name:
+                self.next_screen = screen
 
         curr_screen = self.screens.currentWidget()
 
@@ -182,24 +223,8 @@ class MainWindow(QWidget):
 
 
     def toNextScreen(self):
-        if self.next_screen == self.config_screen:
-            self.toConfigScreen()
-        elif self.next_screen == self.main_screen:
-            self.toMainScreen()
-        elif self.next_screen == self.help_screen:
-            self.toHelpScreen()
-
-    def toConfigScreen(self):
-        self.screens.setCurrentWidget(self.config_screen)
-        self.nav.setTitle(self.config_screen.getTitleText())
-
-    def toHelpScreen(self):
-        self.screens.setCurrentWidget(self.help_screen)
-        self.nav.setTitle(self.help_screen.getTitleText())
-
-    def toMainScreen(self):
-        self.screens.setCurrentWidget(self.main_screen)
-        self.nav.setTitle(self.main_screen.getTitleText())
+        self.screens.setCurrentWidget(self.next_screen)
+        self.nav.setTitle(self.next_screen.getTitleText())
 
     def setStatus(self, msg, timeout):
         self.status.set(msg, timeout)
@@ -207,3 +232,17 @@ class MainWindow(QWidget):
     def nodeSelectionChanged(self, hostname):
         if self.rspecWindow.isVisible():
             self.rspecWindow.showNode(hostname)
+
+    def closeEvent(self, event):
+        # give the screens an opportunity to veto the close
+        for screen in self.screenWidgets:
+            if not screen.canClose():
+                event.ignore()
+                return
+
+        # give the screens an opportunity to close gracefully
+        for screen in self.screenWidgets:
+            screen.mainWindowClose()
+
+        QWidget.closeEvent(self, event)
+