X-Git-Url: http://git.onelab.eu/?p=sface.git;a=blobdiff_plain;f=sface%2Fscreens%2Fmainscreen.py;h=d0ef8c142fb92fa0f1b95ef44060977981744d8f;hp=c25403bd5cf6f7d4ca5c125cf5db211382e895e1;hb=e48c173fad6fa65c628294830f19a913bd9b3d1d;hpb=8fb1ea6942cc6effcc52b93bf0cc4fe204fbc701
diff --git a/sface/screens/mainscreen.py b/sface/screens/mainscreen.py
index c25403b..d0ef8c1 100644
--- a/sface/screens/mainscreen.py
+++ b/sface/screens/mainscreen.py
@@ -75,6 +75,11 @@ class NodeView(QTreeView):
def toggleSelection(self):
index = self.currentIndex()
model = index.model()
+
+ if (model == None):
+ # probably no rspec downloaded yet
+ return
+
status_index = model.index(index.row(), MEMBERSHIP_STATUS_COLUMN, index.parent())
status_data = status_index.data().toString()
node_index = model.index(index.row(), NAME_COLUMN, index.parent())
@@ -125,6 +130,11 @@ class NodeView(QTreeView):
# Right click
index = self.currentIndex()
model = index.model()
+
+ if (model == None):
+ # probably no rspec downloaded yet
+ return
+
status_index = model.index(index.row(), 1, index.parent())
status_data = status_index.data().toString()
node_index = model.index(index.row(), 0, index.parent())
@@ -376,6 +386,16 @@ class SliceWidget(QWidget):
self.updateView()
self.parent().signalAll("rspecUpdated")
+ def deleteSliversFinished(self):
+ self.disconnect(self.process, SIGNAL('finished()'), self.deleteSliversFinished)
+
+ faultString = self.process.getFaultString()
+ if not faultString:
+ self.setStatus("Slice data submitted.")
+ QTimer.singleShot(2500, self.refresh)
+ else:
+ self.setStatus("Slice submit failed: %s" % (faultString))
+
def refreshResourcesFinished(self):
self.disconnect(self.process, SIGNAL('finished()'), self.refreshResourcesFinished)
@@ -423,7 +443,10 @@ class SliceWidget(QWidget):
# Recursively walk the tree, making changes to the RSpec
def process_subtree(self, rspec, rspec_node_names, resource_node_names, item, depth = 0):
- change = False
+ changeAdd = 0
+ changeRemove = 0
+ changeAddTag = 0
+ changeRemoveTag = 0
model = self.nodeModel
if depth in [0, 1]:
@@ -445,11 +468,11 @@ class SliceWidget(QWidget):
rspec.version.add_network(network_name)
rspec.version.add_nodes([resource_node])
rspec.version.add_slivers([str(hostname)])
- change = True
+ changeAdd += 1
elif status == node_status['remove']:
print "Remove hostname: %s" % hostname
rspec.version.remove_slivers([str(hostname)])
- change = True
+ changeRemove += 1
elif depth == 3: # Tag
tag, value = self.itemText(item).split(": ")
status = self.itemStatus(item)
@@ -465,7 +488,7 @@ class SliceWidget(QWidget):
node = rspec_node_names.get(hostname, None)
if node:
rspec.version.add_sliver_attribute(node['component_id'], tag, value, testbed)
- change = True
+ changeAddTag += 1
elif status == tag_status['remove']:
print "Remove tag from (%s, %s): %s/%s " % (testbed, hostname, tag, value)
if hostname.startswith(default_tags):
@@ -474,14 +497,19 @@ class SliceWidget(QWidget):
node = rspec_node_names.get(hostname, None)
if node:
rspec.version.remove_sliver_attribute(node['component_id'], tag, value, testbed)
- change = True
+ changeRemoveTag += 1
children = item.rowCount()
for row in range(0, children):
- status = self.process_subtree(rspec, rspec_node_names, resource_node_names, item.child(row), depth + 1)
- change = change or status
+ (c, ca, cr, cat, crt) = self.process_subtree(rspec, rspec_node_names, resource_node_names, item.child(row), depth + 1)
+ changeAdd = changeAdd + ca
+ changeRemove = changeRemove + cr
+ changeAddTag = changeAddTag + cat
+ changeRemoveTag = changeRemoveTag + crt
- return change
+ change = changeAdd + changeRemove + changeAddTag + changeRemoveTag
+
+ return (change, changeAdd, changeRemove, changeAddTag, changeRemoveTag)
def submit(self):
if self.checkRunningProcess():
@@ -493,12 +521,19 @@ class SliceWidget(QWidget):
resource_node_names = self.nodesByName(resources.version.get_nodes())
rspec_node_names = self.nodesByName(rspec.version.get_nodes_with_slivers())
- change = self.process_subtree(rspec, rspec_node_names, resource_node_names, self.nodeModel.invisibleRootItem())
+ (change, changeAdd, changeRemove, changeAddTag, changeRemoveTag) = \
+ self.process_subtree(rspec, rspec_node_names, resource_node_names, self.nodeModel.invisibleRootItem())
- if not change:
+ if (change <= 0):
self.setStatus("No change in slice data. Not submitting!", timeout=3000)
return
+ if (changeRemove > 0) and (rspec.version.get_nodes_with_slivers() == []):
+ # removing the last sliver in a slice requires us to call deleteSlivers
+ self.connect(self.process, SIGNAL('finished()'), self.deleteSliversFinished)
+ self.process.deleteSlivers()
+ return
+
# Several aggregates have issues with the section in the
# rspec, so make sure it's not there.
stats_elems = rspec.xml.xpath("//statistics")
@@ -517,9 +552,11 @@ class SliceWidget(QWidget):
rspec = SfiData().getSliceRSpec()
resources = SfiData().getResourcesRSpec()
- change = self.process_subtree(rspec, resources, self.nodeModel.invisibleRootItem())
- if not change:
+ (change, changeAdd, changeRemove, changeAddTag, changeRemoveTag) = \
+ self.process_subtree(rspec, rspec, resources, self.nodeModel.invisibleRootItem())
+
+ if (change <= 0):
self.setStatus("No change in slice data. Not submitting!", timeout=3000)
return
@@ -626,10 +663,17 @@ class SliceWidget(QWidget):
self.nodeView.appendRow(nodeItem, tagstring, membership=tag_status['in'], kind = "attribute")
for node in sliver_nodes:
+ nodeType = None
+ if ("hardware_types" in node):
+ hardware_types = [x["name"] for x in node["hardware_types"]]
+ nodeType = ",".join(hardware_types)
+ nodeStatus = node.get("boot_state", "")
+ if nodeStatus == None:
+ nodeStatus=""
nodeItem = self.nodeView.appendRow(networkItem,
node["component_name"],
- nodeStatus=node.get("boot_state", ""),
- #nodeType=node.get("rspec.get_node_sliver_type(node, network),
+ nodeStatus=nodeStatus,
+ nodeType=nodeType,
membership=node_status['in'],
kind="node")
@@ -643,10 +687,17 @@ class SliceWidget(QWidget):
kind="attribute")
for node in available_nodes:
+ nodeType = None
+ if ("hardware_types" in node):
+ hardware_types = [x["name"] for x in node["hardware_types"]]
+ nodeType = ",".join(hardware_types)
+ nodeStatus = node.get("boot_state", "")
+ if nodeStatus == None:
+ nodeStatus=""
self.nodeView.appendRow(networkItem,
node["component_name"],
- nodeStatus = node.get("boot_state", ""),
- #nodeType= resources.get_node_sliver_type(node, network),
+ nodeStatus=nodeStatus,
+ nodeType=nodeType,
membership=node_status['out'],
kind="node")