X-Git-Url: http://git.onelab.eu/?p=sface.git;a=blobdiff_plain;f=sface%2Fsfiprocess.py;fp=sface%2Fsfiprocess.py;h=34608de1cb8aa14541c1256d45f295933155af3d;hp=e06bf9a8bd8a6afd57b0aeec949f0509d52a1097;hb=1a0bb6c8cf51c8abcffdc94da1ba4d9c9bb452e0;hpb=ab5bd9742a2d1b306e1a65b7f37c46f602c3fdd3

diff --git a/sface/sfiprocess.py b/sface/sfiprocess.py
index e06bf9a..34608de 100644
--- a/sface/sfiprocess.py
+++ b/sface/sfiprocess.py
@@ -5,7 +5,7 @@ import time
 
 from PyQt4.QtCore import *
 from sface.config import config
-from sface.xmlrpcwindow import XmlrpcTracker
+from sface.xmlrpcwindow import XmlrpcTracker, XmlrpcReader
 
 def find_executable(exec_name):
     """find the given executable in $PATH"""
@@ -28,7 +28,8 @@ class SfiProcess(QObject):
         self.connect(self.process, SIGNAL("finished(int, QProcess::ExitStatus)"),
                      self.processFinished)
 
-        self.xmlrpctracker = XmlrpcTracker()
+        self.xmlrpcreader = XmlrpcReader() # this one is for parsing XMLRPC responses
+        self.xmlrpctracker = XmlrpcTracker() # this one is for the debug window
 
         # holds aggregate output from processStandardOutput(); used by xmlrpc
         # tracker.
@@ -44,9 +45,11 @@ class SfiProcess(QObject):
         self.args << "-d"
         self.args << config.get_dirname()
 
-        if config.debug:
-            # this shows xmlrpc conversation, see sfi.py docs.
-            self.args << QString('-D')
+        # this shows xmlrpc conversation, see sfi.py docs.
+        # always do this, so we can parse the XML result for faults and show
+        # then to the users.
+        self.args << QString('-D')
+
         for arg in args:
             self.args << QString(arg)
 
@@ -83,9 +86,23 @@ class SfiProcess(QObject):
                 print "ReadError"
             elif err == QProcess.UnknownError:
                 print "UnknownError"
+
+        # extract any faults from the XMLRPC response(s)
+        self.xmlrpcreader.responses = []
+        self.xmlrpcreader.store(self.output)
+        self.xmlrpcreader.extractXml()
+        self.responses = self.xmlrpcreader.responses
+        self.faults = [x for x in self.responses if (x["kind"]=="fault")]
+
         self.trace_end()
         self.emit(SIGNAL("finished()"))
 
+    def getFaultString(self):
+        if self.faults == []:
+            return None
+
+        return self.faults[0].get("faultString","") + " (" + self.faults[0].get("faultCode","") + ")"
+
     def __getRSpec(self, mgr):
         slice = config.getSlice()
         # Write RSpec to file for testing.
@@ -174,6 +191,8 @@ class SfiProcess(QObject):
         self.start()
 
     def start(self):
+        self.respones = []
+        self.faults = []
         self.output = ""
         self.trace_command()
         self.process.start(self.exe, self.args)