better method for accessing faultString

diff --git a/sface/sficreate.py b/sface/sficreate.py
index b4db34a..b3de732 100644 (file)
--- a/sface/sficreate.py
+++ b/sface/sficreate.py
@@ -79,15 +79,14 @@ class CreateWindow(QDialog):
         self.status.setText(x)
 
     def createFinished(self):
-        if self.createProcess.faults==[]:
-            # need to check for success/failure
+        faultString = self.createProcess.getFaultString()
+        if not faultString:
             self.setStatus("<font color='green'>Slice created.</font>")
             self.sliceWasCreated = True
             self.buttonBox.setEnabled(True)
             self.buttonBox.clear()
             self.buttonBox.addButton(QDialogButtonBox.Close)
         else:
-            faultString = self.createProcess.faults[0].get("faultString","")
             self.setStatus("<font color='red'>Slice creation failed: %s</font>" % (faultString))
             self.sliceWasCreated = False
             self.buttonBox.setEnabled(True)

diff --git a/sface/sfiprocess.py b/sface/sfiprocess.py
index b6c5f04..b3be4f6 100644 (file)
--- a/sface/sfiprocess.py
+++ b/sface/sfiprocess.py
@@ -97,6 +97,12 @@ class SfiProcess(QObject):
         self.trace_end()
         self.emit(SIGNAL("finished()"))
 
+    def getFaultString(self):
+        if self.faults == []:
+            return None
+
+        return self.faults[0].get("faultString","") + " (" + self.faults[0].get("faultCode","") + ")"
+
     def __getRSpec(self, mgr):
         slice = config.getSlice()
         # Write RSpec to file for testing.