cfm: No longer keep track of bad remote MPs and MAIDS.
authorEthan Jackson <ethan@nicira.com>
Mon, 28 Mar 2011 20:10:12 +0000 (13:10 -0700)
committerEthan Jackson <ethan@nicira.com>
Mon, 28 Mar 2011 22:44:17 +0000 (15:44 -0700)
commit0dd17bfdfed067cd15f764a5c741625c4c118ac8
tree3cabd3e82c8e9d0a91c61d6ea46df46583373a71
parentde66aa57c7c0b3880fb6592736bc06a91742afca
cfm: No longer keep track of bad remote MPs and MAIDS.

Ben pointed out that an attacker could cause OVS to use infinite
memory by sending a series of CCMs with different MAIDs.  Each
message would cause a remote_maid to be allocated and stored for
several seconds.

Since Commit 1c2e2d2fc8 (cfm: Don't report unexpected remote
endpoints) no longer reports unexpected remote MAIDS and MPs in the
database, the only reason to keep track of this information is for
debugging purposes.  In my judgment, it provides negligible useful
debugging information at the expense of significantly increased
code complexity.  This commit rips it out entirely.
lib/cfm.c
lib/cfm.h