datapath: Fix IP ID setting.
authorJarno Rajahalme <jarno.rajahalme@nsn.com>
Mon, 25 Mar 2013 19:03:38 +0000 (21:03 +0200)
committerJesse Gross <jesse@nicira.com>
Wed, 27 Mar 2013 00:21:25 +0000 (17:21 -0700)
commit0e4c4682f4058e9f51e980ee8c138756a32da45f
tree4f97852cbdf62e0a4cb595c1a207131a5430e3fd
parent26fd9d16d32078ccbea0d8a7bc87d2ed4793039f
datapath: Fix IP ID setting.

Eliminate the extra call to ip_select_ident(), and place the
__ip_select_ident() call where the ip_select_ident() call was.
This fixes two problems: Before, the call to ip_select_ident() did
always zero out the value set earlier by __ip_select_ident().  Also,
when __ip_select_ident() was called before setting the iph->daddr,
ident calculation was possibly based on uninitialized data (but as
the result was masked by the later call to ip_select_ident() it was
not visible).

Signed-off-by: Jarno Rajahalme <jarno.rajahalme@nsn.com>
Signed-off-by: Jesse Gross <jesse@nicira.com>
datapath/tunnel.c