datapath: Calculate flow hash after extracting metadata.
authorJesse Gross <jesse@nicira.com>
Thu, 8 Sep 2011 22:32:24 +0000 (15:32 -0700)
committerJesse Gross <jesse@nicira.com>
Thu, 8 Sep 2011 23:14:02 +0000 (16:14 -0700)
commit21fe5db0c9a8e92bbfce42da89ce20b826216fa1
tree0ee014dfd5bef4f8858b1fcebe0c46d4800e3919
parenta876eb5a8bf568a25ee1101bb04ee65bcee56161
datapath: Calculate flow hash after extracting metadata.

When we execute a packet from userspace we first extract the header
fields from the packet and then add supplied metadata.  However, we
compute the hash of the packet in between these two steps despite
the fact that the metadata can affect the hash.  This can lead to
two separate hashes for packets of the same flow.

Found by code inspection, not an actual real-world problem.

Signed-off-by: Jesse Gross <jesse@nicira.com>
Acked-by: Ben Pfaff <blp@nicira.com>
datapath/datapath.c