tunneling: Don't send ICMP messages if no tunnel port is found.
authorJesse Gross <jesse@nicira.com>
Fri, 1 Feb 2013 23:34:10 +0000 (15:34 -0800)
committerJesse Gross <jesse@nicira.com>
Sat, 2 Feb 2013 01:07:10 +0000 (17:07 -0800)
commit498e12855516a9009fcfff3d1a2d475ead1822ca
tree20c71aeb1bffd18ba181d068db0fad9f26a9e14d
parentcc2862a93261e9fc9c3880982a9f45e10061733f
tunneling: Don't send ICMP messages if no tunnel port is found.

Some tunnel code in OVS (for example, CAPWAP) uses the skb->cb to
store information while processing packets.  However, if we don't
find an appropriate tunnel port on receive, then we send an ICMP
port unreachable message, which calls back into the IP stack.  The
stack assumes that skb->cb will still contain valid information
about from the IP layer, including any IP options.  As a result,
icmp_echo_options() can read the garbage values from OVS and
overwrite data on the stack, panicing the machine.

This simply stops sending ICMP messages when ports are not found.
Many people find them confusing and flow based tunneling will
never send them (since it always finds a port) so it solves both
problems at once.

Bug #14880

Reported-by: Deepesh Govindan <dgovindan@nicira.com>
Signed-off-by: Jesse Gross <jesse@nicira.com>
Acked-by: Kyle Mestery <kmestery@cisco.com>
datapath/vport-capwap.c
datapath/vport-gre.c
datapath/vport-vxlan.c