cfm: No longer trigger fault upon unexpected ccm_interval.
authorEthan Jackson <ethan@nicira.com>
Thu, 12 May 2011 00:55:41 +0000 (17:55 -0700)
committerEthan Jackson <ethan@nicira.com>
Fri, 13 May 2011 20:09:27 +0000 (13:09 -0700)
commit5e80932275419e688b3ad608d6371867953fe4b9
treecf9f9a782a4a331d44f77dd0d891740c15127d87
parente3f55cb8b25d03d8cb81f12a976c2ff1154e2826
cfm: No longer trigger fault upon unexpected ccm_interval.

According to the 802.1ag specification, when a CCM is received
which advertises a misconfigured transmission interval, a fault
should be triggered.  This patch goes against the spec by simply
warning when this happens.  This is done for several reasons.

  - Faults can cause controllers to make potentially expensive
    changes in the network topology.
  - Faults can be maliciously triggered by crafting invalid CCMs.
  - Reducing the number of places in the code where rmp->fault and
    cfm->fault are changed makes the code easier to debug and
    reason about.
lib/cfm.c