ofp-actions: Fix the check for instruction ordering and duplication.
authorBen Pfaff <blp@nicira.com>
Thu, 3 Jan 2013 17:02:52 +0000 (09:02 -0800)
committerBen Pfaff <blp@nicira.com>
Thu, 3 Jan 2013 20:22:16 +0000 (12:22 -0800)
commit6813ee7c06fbd2496fb73edd54a462a9053c6161
treee01b78be151d4e6bfd73b6ec9752431aaa245668
parentab3a09c87863526ca31a36fc21877c2ce505e447
ofp-actions: Fix the check for instruction ordering and duplication.

Open vSwitch enforces that, when instructions appear as Nicira extensions
in OpenFlow 1.0 action lists, the instructions appear in the order that
an OpenFlow 1.1+ switch would execute them and that no duplicates appear.
But the check wasn't general enough, because it had been implemented when
only one instruction was implemented and never later generalized.  This
commit fixes the problem.

One of the tests was actually testing for the wrong behavior that the
check implemented, so this commit corrects that test.  It also updates
another test with updated log messages.

Reported-by: Jing Ai <ai_jing2000@hotmail.com>
Tested-by: Jing Ai <ai_jing2000@hotmail.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
AUTHORS
lib/ofp-actions.c
tests/ofp-actions.at