bridge: Let ofprotos run once before reporting configuration complete.
authorBen Pfaff <blp@nicira.com>
Mon, 30 Sep 2013 20:07:35 +0000 (13:07 -0700)
committerBen Pfaff <blp@nicira.com>
Tue, 17 Dec 2013 22:13:49 +0000 (14:13 -0800)
commitaeed7879059792858d27cd22619326dae214047a
tree2a0dee6a77e60159ff68b45626850eb81809ac6f
parent1ce3fa06fc82210e2ed70b36e2842fe39d91b995
bridge: Let ofprotos run once before reporting configuration complete.

Occasionally in the unit tests the following race can happen:

   1. ovs-vsctl updates database
   2. ovs-vswitchd reconfigures, notifies ovs-vsctl that it is complete
   3. ovs-appctl ofproto/trace fails to see newly added port
   4. ovs-vswitchd main loop calls ofproto's ->type_run(), making the
      new port visible to translation.

This race may be seen in the failures of tests 5 and 624 here:
https://launchpadlibrarian.net/151884888/buildlog_ubuntu-precise-amd64.openvswitch_2.0~201309300804-1ppa1~precise_FAILEDTOBUILD.txt.gz

Reported-by: Vasiliy Tolstov <v.tolstov@selfip.ru>
Signed-off-by: Ben Pfaff <blp@nicira.com>
AUTHORS
vswitchd/bridge.c