ofproto-dpif: Actually log errors in facet_check_consistency()
authorSimon Horman <horms@verge.net.au>
Wed, 5 Jun 2013 13:28:47 +0000 (13:28 +0000)
committerEthan Jackson <ethan@nicira.com>
Thu, 6 Jun 2013 18:11:57 +0000 (11:11 -0700)
commitc0a71f4e62617a9dbdd19089e22ec29b594f3860
treef26bee2d88a4687fb964973d35965e855e430d71
parent37cd552e93cef42145adc9b8b219710a0296f6f9
ofproto-dpif: Actually log errors in facet_check_consistency()

facet_check_consistency() goes to some effort to create informative
error messages, protected by a rate limit, but does not actually
log these messages.

This appears to be an unintended side effect of
4dff90977694784e67e9c08cc72dee28ebc343ae ("ofproto-dpif: Move
odp_actions from subfacet to facet.").  This patch restores the
logging behaviour present prior to the above commit.

This patch also reverses a changes made by the same commit to use
ds_put_cstr() instead of ds_put_char() in facet_check_consistency().

Cc: Justin Pettit <jpettit@nicira.com>
Cc: Ethan Jackson <ethan@nicira.com>
Signed-off-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Ethan Jackson <ethan@nicira.com>
ofproto/ofproto-dpif.c