ofproto-dpif: Zero-out subfacet counters when installation fails.
authorJustin Pettit <jpettit@nicira.com>
Fri, 12 Jul 2013 23:56:55 +0000 (16:56 -0700)
committerJustin Pettit <jpettit@nicira.com>
Sat, 13 Jul 2013 01:49:09 +0000 (18:49 -0700)
commitcfd5c9eb1d9e94222d954b7f52040cd111b6640e
tree96358af82bd3e96a5c682363de2161d31080bfcc
parent92fa2e9272a5d2120339f106ba39285d5dac8d44
ofproto-dpif: Zero-out subfacet counters when installation fails.

When deleting subfacets, subfacet_uninstall() asserts that the
subfacet's counters are zero to make sure we don't lose counters.  We
have seen cases where a subfacet cannot be installed, but the counters
have values.  This should not happen and indicates a bug, since we
shouldn't create a subfacet if the datapath has a flow.  A buggy
datapath could trigger this, so just zero out the counters and log an
error.

Bug #18460.

Signed-off-by: Justin Pettit <jpettit@nicira.com>
ofproto/ofproto-dpif.c