coverage: Make the coverage counters catalog program-specific.
authorBen Pfaff <blp@nicira.com>
Mon, 1 Nov 2010 21:14:27 +0000 (14:14 -0700)
committerBen Pfaff <blp@nicira.com>
Tue, 30 Nov 2010 18:30:30 +0000 (10:30 -0800)
commitd76f09ea77e03ee5a3a7bb67bcab1ac4bb54172b
tree51f5b6b4090380591410d830e6fa57d02185e629
parentf4e2e60be455af4d5bd294cfe19a7cb4ea13a9ff
coverage: Make the coverage counters catalog program-specific.

Until now, the collection of coverage counters supported by a given OVS
program was not specific to that program.  That means that, for example,
even though ovs-dpctl does not have anything to do with mac_learning, it
still has a coverage counter for it.  This is confusing, at best.

This commit fixes the problem on some systems, in particular on ones that
use GCC and the GNU linker.  It uses the feature of the GNU linker
described in its manual as:

    If an orphaned section's name is representable as a C identifier then
    the linker will automatically see PROVIDE two symbols: __start_SECNAME
    and __end_SECNAME, where SECNAME is the name of the section.  These
    indicate the start address and end address of the orphaned section
    respectively.

Systems that don't support these features retain the earlier behavior.

This commit also fixes the annoyance that files that include coverage
counters must be listed on COVERAGE_FILES in lib/automake.mk.

This commit also fixes the annoyance that modifying any source file that
includes a coverage counter caused all programs that link against
libopenvswitch.a to relink, even programs that the source file was not
linked into.  For example, modifying ofproto/ofproto.c (which includes
coverage counters) caused tests/test-aes128 to relink, even though
test-aes128 does not link again ofproto.o.
25 files changed:
lib/automake.mk
lib/coverage-counters.h [deleted file]
lib/coverage-scan.pl [deleted file]
lib/coverage.c
lib/coverage.h
lib/dpif.c
lib/flow.c
lib/hmap.c
lib/lockfile.c
lib/mac-learning.c
lib/netdev-linux.c
lib/netdev.c
lib/netlink.c
lib/poll-loop.c
lib/process.c
lib/rconn.c
lib/rtnetlink.c
lib/stream-ssl.c
lib/stream.c
lib/unixctl.c
lib/util.c
lib/vconn.c
ofproto/ofproto.c
ofproto/pktbuf.c
vswitchd/bridge.c