netdev-linux: Fix use-after-free when netdev_dump_queues() deletes queues.
authorBen Pfaff <blp@nicira.com>
Mon, 19 Mar 2012 20:47:50 +0000 (13:47 -0700)
committerBen Pfaff <blp@nicira.com>
Mon, 19 Mar 2012 20:53:00 +0000 (13:53 -0700)
commite608ee3073446c2bba8aaca0c6c31789b0533a0a
treec5638baa64538a510f61ce275d64dbba8cb3ea31
parent0d4000c2f610fe4b7e5b19d3a5fe8dc7a0d5fd08
netdev-linux: Fix use-after-free when netdev_dump_queues() deletes queues.

iface_configure_qos() passes a callback to netdev_dump_queues() that can
delete queues.  The netdev-linux implementation of this function was
unprepared for the callback to delete queues, so this could cause a
use-after-free.  This fixes the problem in netdev_linux_dump_queues() and
documents that netdev_dump_queues() implementations must support deletions
in the callback.

Found by valgrind:

==1593== Invalid read of size 8
==1593==    at 0x4A8C43: netdev_linux_dump_queues (hmap.h:326)
==1593==    by 0x4305F7: bridge_reconfigure (bridge.c:3084)
==1593==    by 0x431384: bridge_run (bridge.c:1892)
==1593==    by 0x432749: main (ovs-vswitchd.c:96)
==1593==  Address 0x632e078 is 8 bytes inside a block of size 32 free'd
==1593==    at 0x4C240FD: free (vg_replace_malloc.c:366)
==1593==    by 0x4A4D74: hfsc_class_delete (netdev-linux.c:3250)
==1593==    by 0x42AA59: iface_delete_queues (bridge.c:3055)
==1593==    by 0x4A8C8C: netdev_linux_dump_queues (netdev-linux.c:1881)
==1593==    by 0x4305F7: bridge_reconfigure (bridge.c:3084)
==1593==    by 0x431384: bridge_run (bridge.c:1892)

Bug #10164.
Reported-by: Ram Jothikumar <ram@nicira.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
lib/netdev-linux.c
lib/netdev-provider.h
lib/netdev.c