Always use valid ids pointer in dec_ttl_cnt_ids_from_openflow()
authorSimon Horman <horms@verge.net.au>
Mon, 3 Jun 2013 05:46:30 +0000 (14:46 +0900)
committerBen Pfaff <blp@nicira.com>
Tue, 4 Jun 2013 17:23:06 +0000 (10:23 -0700)
commite655542cf3cc10f14651fb237582ac7e55683e88
tree6d5b831f045ed19e1c8070ced90518159bd263f7
parent9d46b444e3d7b57e5d0500bc12d3301fe528627c
Always use valid ids pointer in dec_ttl_cnt_ids_from_openflow()

Always update the ids pointer after calling ofpbuf_put()
to ensure that it is valid when accessed.

During testing a case came up where the call to ofpbuf_put() in the
for (i = 0; i < ids->n_controllers; i++) loop would cause the underlying
buffer to be reallocated. This resulted in ids->n_controllers being an
incorrect value, the loop continuing on longer than desired and finally a
segmentation fault.

Reported-by: Joe Stringer <joe@wand.net.nz>
Signed-off-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Ben Pfaff <blp@nicira.com>
lib/ofp-actions.c