ofproto-dpif: keep slow path flow time stamp up-to-date
authorBen Pfaff <blp@nicira.com>
Fri, 22 Nov 2013 23:57:23 +0000 (15:57 -0800)
committerAndy Zhou <azhou@nicira.com>
Mon, 2 Dec 2013 22:19:44 +0000 (14:19 -0800)
commitf9c372331477c9b5c419c91687d5490570d4ac89
tree7e87fb4a5d352e366875cabbf478ba770f77d70c
parent1f521ded3b3605a01a2dfe577ed5562f47c6a034
ofproto-dpif: keep slow path flow time stamp up-to-date

Noting updating slow path subfacet's time stamp can cause their datapath
flows deleted periodically. For example, CFM datapath flow have usespace
actions that are handled in dpif slow path. They are deleted and
recreated periodically without the fix.

This bug are not obvious during normal operation. Deleted CFM flow
would cause CFM packets to be handled by flow miss handler which will
reinstall the flow in the datapath. The only potentially observable
behavior is that when the user space is overwhelmed with flow miss packets,
the periodic CFM miss packets may get stuck behind other miss packets,
cause tunnel flapping.

Ben refactored the patch to its current form.

Reported-by: Guolin Yang <gyang@nicira.com>
Co-authored-by: Ben Pfaff <blp@nicira.com>
Signed-off-by: Andy Zhou <azhou@nicira.com>
ofproto/ofproto-dpif.c