From: Pravin B Shelar Date: Wed, 18 Dec 2013 18:57:33 +0000 (-0800) Subject: datapath: Fix build failure on RHEL 6.4 X-Git-Tag: sliver-openvswitch-2.1.90-1~10^2~110 X-Git-Url: http://git.onelab.eu/?p=sliver-openvswitch.git;a=commitdiff_plain;h=0aa6fda799596bea3a0103c7fa0d6afe2eaeeea6 datapath: Fix build failure on RHEL 6.4 Patch fixes following build failure:- make[4]: Entering directory `/usr/src/kernels/2.6.32-358.18.1.el6.x86_64' CC [M] openvswitch/datapath/linux/actions.o In file included from openvswitch/datapath/linux/actions.c:21: openvswitch/datapath/linux/compat/include/linux/skbuff.h:273: error: redefinition of ‘__skb_fill_page_desc’ include/linux/skbuff.h:1123: note: previous definition of ‘__skb_fill_page_desc’ was here ----- Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross --- diff --git a/acinclude.m4 b/acinclude.m4 index 2ca931114..321b3b026 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -256,6 +256,7 @@ AC_DEFUN([OVS_CHECK_LINUX_COMPAT], [ [OVS_DEFINE([HAVE_SKB_WARN_LRO])]) OVS_GREP_IFELSE([$KSRC/include/linux/skbuff.h], [consume_skb]) OVS_GREP_IFELSE([$KSRC/include/linux/skbuff.h], [skb_frag_page]) + OVS_GREP_IFELSE([$KSRC/include/linux/skbuff.h], [__skb_fill_page_desc]) OVS_GREP_IFELSE([$KSRC/include/linux/skbuff.h], [skb_reset_mac_len]) OVS_GREP_IFELSE([$KSRC/include/linux/skbuff.h], [skb_unclone]) diff --git a/datapath/linux/compat/include/linux/skbuff.h b/datapath/linux/compat/include/linux/skbuff.h index 41ec9517f..d1224ac12 100644 --- a/datapath/linux/compat/include/linux/skbuff.h +++ b/datapath/linux/compat/include/linux/skbuff.h @@ -269,7 +269,7 @@ void skb_zerocopy(struct sk_buff *to, const struct sk_buff *from, int len, #define skb_has_frag_list skb_has_frags #endif -#if LINUX_VERSION_CODE < KERNEL_VERSION(3,2,0) +#ifndef HAVE___SKB_FILL_PAGE_DESC static inline void __skb_fill_page_desc(struct sk_buff *skb, int i, struct page *page, int off, int size) {