From: Ben Pfaff Date: Fri, 15 Apr 2011 16:31:36 +0000 (-0700) Subject: Fix calls to ctype functions. X-Git-Tag: v1.1.1~27 X-Git-Url: http://git.onelab.eu/?p=sliver-openvswitch.git;a=commitdiff_plain;h=101c55a1af7998a009a5c88c20e30837bc1a9765 Fix calls to ctype functions. The ctype functions often need casts to be fully C standards compliant. Here's the full explanation that I used to post to comp.lang.c from time to time when the issue came up: With the to*() and is*() functions, you should be careful to cast `char' arguments to `unsigned char' before calling them. Type `char' may be signed or unsigned, depending on your compiler or its configuration. If `char' is signed, then some characters have negative values; however, the arguments to is*() and to*() functions must be nonnegative (or EOF). Casting to `unsigned char' fixes this problem by forcing the character to the corresponding positive value. This fixes the following warnings from some version of GCC: lib/ofp-parse.c:828: warning: array subscript has type 'char' lib/ofp-print.c:617: warning: array subscript has type 'char' Reported-by: YAMAMOTO Takashi --- diff --git a/AUTHORS b/AUTHORS index bc0f3f6a0..180428af8 100644 --- a/AUTHORS +++ b/AUTHORS @@ -80,6 +80,7 @@ Stephen Hemminger shemminger@vyatta.com Takayuki HAMA t-hama@cb.jp.nec.com Teemu Koponen koponen@nicira.com Vishal Swarankar vishal.swarnkar@gmail.com +YAMAMOTO Takashi yamamoto@valinux.co.jp Yongqiang Liu liuyq7809@gmail.com kk yap yapkke@stanford.edu diff --git a/lib/ofp-parse.c b/lib/ofp-parse.c index de7cd9c72..a3492cbc6 100644 --- a/lib/ofp-parse.c +++ b/lib/ofp-parse.c @@ -820,7 +820,8 @@ parse_ofp_str(struct flow_mod *fm, uint8_t *table_idx, } else { parse_field_value(&fm->cr, f->index, value); } - } else if (!strncmp(name, "reg", 3) && isdigit(name[3])) { + } else if (!strncmp(name, "reg", 3) + && isdigit((unsigned char) name[3])) { unsigned int reg_idx = atoi(name + 3); if (reg_idx >= FLOW_N_REGS) { ovs_fatal(0, "only %d registers supported", FLOW_N_REGS); diff --git a/lib/ofp-print.c b/lib/ofp-print.c index 1cd946260..32e8e7c32 100644 --- a/lib/ofp-print.c +++ b/lib/ofp-print.c @@ -603,7 +603,7 @@ ofp_print_phy_port(struct ds *string, const struct ofp_phy_port *port) memcpy(name, port->name, sizeof name); for (j = 0; j < sizeof name - 1; j++) { - if (!isprint(name[j])) { + if (!isprint((unsigned char) name[j])) { break; } }