From: Hong Zhiguo <honkiko@gmail.com>
Date: Wed, 27 Mar 2013 15:14:43 +0000 (-0700)
Subject: datapath: correct an invalid BUG_ON
X-Git-Tag: sliver-openvswitch-1.10.90-1~10^2~30
X-Git-Url: http://git.onelab.eu/?p=sliver-openvswitch.git;a=commitdiff_plain;h=49c7f80c1a27b1619dfa81e413a112d52f3de462

datapath: correct an invalid BUG_ON

table->count is uint32_t

Signed-off-by: Hong Zhiguo <honkiko@gmail.com>
Signed-off-by: Jesse Gross <jesse@nicira.com>
---

diff --git a/datapath/flow.c b/datapath/flow.c
index afebc7a28..2aeb7040d 100644
--- a/datapath/flow.c
+++ b/datapath/flow.c
@@ -825,9 +825,9 @@ void ovs_flow_tbl_insert(struct flow_table *table, struct sw_flow *flow,
 
 void ovs_flow_tbl_remove(struct flow_table *table, struct sw_flow *flow)
 {
+	BUG_ON(table->count == 0);
 	hlist_del_rcu(&flow->hash_node[table->node_ver]);
 	table->count--;
-	BUG_ON(table->count < 0);
 }
 
 /* The size of the argument for each %OVS_KEY_ATTR_* Netlink attribute.  */