From: Ben Pfaff Date: Thu, 5 Dec 2013 19:43:50 +0000 (-0800) Subject: bridge: Improve iface_set_ofport() style. X-Git-Url: http://git.onelab.eu/?p=sliver-openvswitch.git;a=commitdiff_plain;h=820b35a330191a63e0c538de2dce27ca09e43627 bridge: Improve iface_set_ofport() style. This should behave the same as before but the code reads more naturally to me this way. Signed-off-by: Ben Pfaff Acked-by: Ethan Jackson --- diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index 6ce7d2b33..0f4cf2c2e 100644 --- a/vswitchd/bridge.c +++ b/vswitchd/bridge.c @@ -3594,10 +3594,9 @@ iface_set_mac(struct iface *iface) static void iface_set_ofport(const struct ovsrec_interface *if_cfg, ofp_port_t ofport) { - int64_t port_; - port_ = (ofport == OFPP_NONE) ? -1 : ofp_to_u16(ofport); if (if_cfg && !ovsdb_idl_row_is_synthetic(&if_cfg->header_)) { - ovsrec_interface_set_ofport(if_cfg, &port_, 1); + int64_t port = ofport == OFPP_NONE ? -1 : ofp_to_u16(ofport); + ovsrec_interface_set_ofport(if_cfg, &port, 1); } }