From: Pravin B Shelar Date: Thu, 18 Apr 2013 23:00:48 +0000 (-0700) Subject: datapath: Fix inconsistency in upstream and out of tree ovs module. X-Git-Url: http://git.onelab.eu/?p=sliver-openvswitch.git;a=commitdiff_plain;h=8680ae4deb6b734b1aaa6ceec4810a682dd3d9e3 datapath: Fix inconsistency in upstream and out of tree ovs module. There is a inconsistent ordering in function ovs_vport_cmd_set() between upstream and out of tree ovs module. Following patch fixes it by releasing lock before calling ovs_notify. Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross --- diff --git a/datapath/datapath.c b/datapath/datapath.c index a8bb5b864..3cb58b0ee 100644 --- a/datapath/datapath.c +++ b/datapath/datapath.c @@ -2130,9 +2130,8 @@ static int ovs_vport_cmd_set(struct sk_buff *skb, struct genl_info *info) info->snd_seq, 0, OVS_VPORT_CMD_NEW); BUG_ON(err < 0); - ovs_notify(reply, info, &ovs_dp_vport_multicast_group); - ovs_unlock(); + ovs_notify(reply, info, &ovs_dp_vport_multicast_group); return 0; exit_free: