From: Giuseppe Lettieri <g.lettieri@iet.unipi.it>
Date: Mon, 17 Sep 2012 19:17:44 +0000 (+0200)
Subject: use builtin --if-exists/--may-exist
X-Git-Tag: sliver-openvswitch-1.8.90-0~10
X-Git-Url: http://git.onelab.eu/?p=sliver-openvswitch.git;a=commitdiff_plain;h=d0a72100346ee2695cbb23134d7bc7f5ba4865a7

use builtin --if-exists/--may-exist

We use the builtin functionality of ovs-vsctl to check
for already existing bridges and ports on creation,
or already non existing ones on deletion. In this way
we get a more significant return value from ovs-vsctl
in case of error.
---

diff --git a/planetlab/scripts/sliver-ovs.in b/planetlab/scripts/sliver-ovs.in
index 84fac40cf..01089ee8c 100755
--- a/planetlab/scripts/sliver-ovs.in
+++ b/planetlab/scripts/sliver-ovs.in
@@ -189,7 +189,6 @@ EOF
     wait_device $TAPNAME 60 && \
 	ovs-vsctl --db=unix:$DB_SOCKET add-br $TAPNAME -- set bridge $TAPNAME datapath_type=planetlab
     echo $TAPNAME
-    return 0
 }
 
 function create_port () {
@@ -200,11 +199,8 @@ function create_port () {
     is_switch_running || { echo "ovs-vswitchd not running" >&2 ; exit 1 ; }
 
     set -e
-    if ! ovs-vsctl --db=unix:$DB_SOCKET list-ports "$bridge" | grep -q "^$port\$"; then
-	ovs-vsctl --db=unix:$DB_SOCKET add-port "$bridge" "$port" -- set interface "$port" type=tunnel
-    fi
+    ovs-vsctl --db=unix:$DB_SOCKET -- --may-exist add-port "$bridge" "$port" -- set interface "$port" type=tunnel
     ovs-appctl --target=ovs-vswitchd netdev-tunnel/get-port "$port"
-    return 0
 }
 
 function set_remote_endpoint () {
@@ -218,7 +214,6 @@ function set_remote_endpoint () {
     ovs-vsctl --db=unix:$DB_SOCKET set interface $local_port \
         options:remote_ip=$remote_ip \
 	options:remote_port=$remote_UDP_port
-    return 0
 }
 
 #################### del functions
@@ -234,10 +229,7 @@ function del_bridge () {
     	W="--no-wait"
     fi
 
-    if ovs-vsctl --db=unix:$DB_SOCKET br-exists "$bridge_name"; then
-	ovs-vsctl --db=unix:$DB_SOCKET $W del-br $bridge_name
-    fi
-    return 0
+    ovs-vsctl --db=unix:$DB_SOCKET $W -- --if-exists del-br $bridge_name
 }
 
 function del_port () {
@@ -252,11 +244,7 @@ function del_port () {
     	W="--no-wait"
     fi
 
-    set -e
-    if ovs-vsctl --db=unix:$DB_SOCKET port-to-br "$port" >/dev/null 2>&1; then
-	ovs-vsctl --db=unix:$DB_SOCKET $W del-port "$port"
-    fi
-    return 0
+    ovs-vsctl --db=unix:$DB_SOCKET $W -- --if-exists del-port "$port"
 }
 
 function show () {