From: Simon Horman <horms@verge.net.au>
Date: Wed, 25 Aug 2010 03:10:32 +0000 (+0900)
Subject: datapath: Unconditionally call kfree_skb()
X-Git-Tag: v1.1.0pre1~54
X-Git-Url: http://git.onelab.eu/?p=sliver-openvswitch.git;a=commitdiff_plain;h=f2d9c30bdf455d8ce6dbf2188c1330e4b33d7d1f

datapath: Unconditionally call kfree_skb()

kfree_skb() will ignore a NULL pointer.

Signed-off-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Jesse Gross <jesse@nicira.com>
---

diff --git a/datapath/brcompat.c b/datapath/brcompat.c
index b68720bd8..44b2c9923 100644
--- a/datapath/brcompat.c
+++ b/datapath/brcompat.c
@@ -425,8 +425,7 @@ static int brc_genl_dp_result(struct sk_buff *skb, struct genl_info *info)
 	if (brc_seq == info->snd_seq) {
 		brc_seq++;
 
-		if (brc_reply)
-			kfree_skb(brc_reply);
+		kfree_skb(brc_reply);
 		brc_reply = skb;
 
 		complete(&brc_done);