From 25d6a6a8803761cf321ba45d1eeb6df29c2a6c6e Mon Sep 17 00:00:00 2001 From: Simon Horman Date: Thu, 1 May 2014 16:40:17 +0000 Subject: [PATCH] ofproto-dpif: Make bonding balance test more robust It is my observation that when sending 91 packets to a mode=balance bond interface with three underlying ports in some cases not all ports receive at least 7 packets. This causes the test to fail. It may be that failure indicates that the bonding code needs improvement. But it seems to me that its more likely to be a valid behaviour. I have found that by sending 256 packets instead of 91 the test passes more reliably: I am yet to see it fail. Signed-off-by: Simon Horman Signed-off-by: Andy Zhou --- tests/ofproto-dpif.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at index a32bc4111..c46e99748 100644 --- a/tests/ofproto-dpif.at +++ b/tests/ofproto-dpif.at @@ -178,7 +178,7 @@ ovs-appctl time/warp 100 ovs-appctl lacp/show > lacp.txt ovs-appctl bond/show > bond.txt ( -for i in `seq 10 100` ; +for i in `seq 0 255` ; do pkt="in_port(7),eth(src=50:54:00:00:00:05,dst=50:54:00:00:01:00),eth_type(0x0800),ipv4(src=10.0.0.2,dst=10.0.0.1,proto=6,tos=0,ttl=64,frag=no),tcp(src=8,dst=$i),tcp_flags(0x010)" AT_CHECK([ovs-appctl netdev-dummy/receive p7 $pkt]) -- 2.43.0