From 4c9dbc0b14865eede43bae743058d25be8c191fb Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Mon, 17 Mar 2014 13:25:19 -0700 Subject: [PATCH] ofproto-dpif: Revalidate flows when the group table changes. Otherwise group table modifications won't be immediately reflected in the treatment of flows already passing through the switch. Reported-by: Hyojoon Kim Signed-off-by: Ben Pfaff Tested-by: Hyojoon Kim --- AUTHORS | 1 + ofproto/ofproto-dpif.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/AUTHORS b/AUTHORS index 34e53c321..e8d35d5be 100644 --- a/AUTHORS +++ b/AUTHORS @@ -179,6 +179,7 @@ Hector Oron hector.oron@gmail.com Henrik Amren henrik@nicira.com Hiroshi Tanaka htanaka@nicira.com Hiroshi Miyata miyahiro.dazu@gmail.com +Hyojoon Kim joonk@gatech.edu Igor Ganichev iganichev@nicira.com Igor Sever igor@xorops.com Jacob Cherkas jcherkas@nicira.com diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index bb414f2b3..bda1d33a4 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofproto-dpif.c @@ -3339,6 +3339,7 @@ group_destruct(struct ofgroup *group_) static enum ofperr group_modify(struct ofgroup *group_, struct ofgroup *victim_) { + struct ofproto_dpif *ofproto = ofproto_dpif_cast(group_->ofproto); struct group_dpif *group = group_dpif_cast(group_); struct group_dpif *victim = group_dpif_cast(victim_); @@ -3349,6 +3350,8 @@ group_modify(struct ofgroup *group_, struct ofgroup *victim_) group_construct_stats(group); ovs_mutex_unlock(&group->stats_mutex); + ofproto->backer->need_revalidate = REV_FLOW_TABLE; + return 0; } -- 2.43.0