From 6cc17de80fab26cc7392e8edc46d67cbda250283 Mon Sep 17 00:00:00 2001 From: Jarno Rajahalme Date: Thu, 24 Oct 2013 13:19:33 -0700 Subject: [PATCH] lib/ofp-actions: Warn on deprecated actions. Signed-off-by: Jarno Rajahalme Signed-off-by: Ben Pfaff --- lib/ofp-actions.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c index 2b4b45c75..77fcb8324 100644 --- a/lib/ofp-actions.c +++ b/lib/ofp-actions.c @@ -1105,6 +1105,24 @@ ofpact_from_openflow11(const union ofp_action *a, enum ofp_version version, return error; } + if (version >= OFP12_VERSION) { + switch ((int)code) { + case OFPUTIL_OFPAT11_SET_VLAN_VID: + case OFPUTIL_OFPAT11_SET_VLAN_PCP: + case OFPUTIL_OFPAT11_SET_DL_SRC: + case OFPUTIL_OFPAT11_SET_DL_DST: + case OFPUTIL_OFPAT11_SET_NW_SRC: + case OFPUTIL_OFPAT11_SET_NW_DST: + case OFPUTIL_OFPAT11_SET_NW_TOS: + case OFPUTIL_OFPAT11_SET_NW_ECN: + case OFPUTIL_OFPAT11_SET_TP_SRC: + case OFPUTIL_OFPAT11_SET_TP_DST: + VLOG_WARN_RL(&rl, "Deprecated action %s received over %s", + ofputil_action_name_from_code(code), + ofputil_version_to_string(version)); + } + } + switch (code) { case OFPUTIL_ACTION_INVALID: #define OFPAT10_ACTION(ENUM, STRUCT, NAME) case OFPUTIL_##ENUM: -- 2.43.0