From 71c24bb0f881fde3304de61e19bb4e0c5512da30 Mon Sep 17 00:00:00 2001 From: Alex Wang Date: Fri, 21 Feb 2014 14:03:51 -0800 Subject: [PATCH] dpif-netdev: Fix memory leak. In dpif_netdev_flow_del() and dp_netdev_port_input(), the referenced 'netdev_flow' is not un-referenced. This causes the leak of the struct's memory. This commit fixes the above issue by calling dp_netdev_flow_unref() after using the reference. Signed-off-by: Alex Wang Acked-by: Ben Pfaff --- lib/dpif-netdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 9ba93dd07..c4ba64633 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -1295,6 +1295,7 @@ dpif_netdev_flow_del(struct dpif *dpif, const struct dpif_flow_del *del) ovs_mutex_unlock(&netdev_flow->mutex); } dp_netdev_remove_flow(dp, netdev_flow); + dp_netdev_flow_unref(netdev_flow); } else { error = ENOENT; } @@ -1706,6 +1707,7 @@ dp_netdev_port_input(struct dp_netdev *dp, struct ofpbuf *packet, dp_netdev_execute_actions(dp, &key, packet, md, actions->actions, actions->size); dp_netdev_actions_unref(actions); + dp_netdev_flow_unref(netdev_flow); ovsthread_counter_inc(dp->n_hit, 1); } else { ovsthread_counter_inc(dp->n_missed, 1); -- 2.43.0